Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: components/proximity_auth/cryptauth/cryptauth_access_token_fetcher_unittest.cc

Issue 1066453002: Refactor CryptAuth component to be more testable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cryptauth_securemessage
Patch Set: rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/proximity_auth/cryptauth/cryptauth_access_token_fetcher_unittest.cc
diff --git a/components/proximity_auth/cryptauth/cryptauth_account_token_fetcher_unittest.cc b/components/proximity_auth/cryptauth/cryptauth_access_token_fetcher_unittest.cc
similarity index 61%
rename from components/proximity_auth/cryptauth/cryptauth_account_token_fetcher_unittest.cc
rename to components/proximity_auth/cryptauth/cryptauth_access_token_fetcher_unittest.cc
index 74fb5a352a66e5dc9dedfd59eb100c901fc71527..697e0ea9f6fea14784b7dd9b2249a24313b4afae 100644
--- a/components/proximity_auth/cryptauth/cryptauth_account_token_fetcher_unittest.cc
+++ b/components/proximity_auth/cryptauth/cryptauth_access_token_fetcher_unittest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "components/proximity_auth/cryptauth/cryptauth_account_token_fetcher.h"
+#include "components/proximity_auth/cryptauth/cryptauth_access_token_fetcher.h"
#include <string>
@@ -25,31 +25,32 @@ void SaveAccessToken(std::string* out_token, const std::string& in_token) {
} // namespace
-class ProximityAuthCryptAuthAccountTokenFetcherTest : public testing::Test {
+class ProximityAuthCryptAuthAccessTokenFetcherTest : public testing::Test {
protected:
- ProximityAuthCryptAuthAccountTokenFetcherTest()
- : fetcher_(&token_service_, kAccountId) {
+ ProximityAuthCryptAuthAccessTokenFetcherTest()
+ : fetcher_(CryptAuthAccessTokenFetcher::CreateDefault(&token_service_,
+ kAccountId)) {
token_service_.AddAccount(kAccountId);
}
FakeOAuth2TokenService token_service_;
- CryptAuthAccountTokenFetcher fetcher_;
+ scoped_ptr<CryptAuthAccessTokenFetcher> fetcher_;
- DISALLOW_COPY_AND_ASSIGN(ProximityAuthCryptAuthAccountTokenFetcherTest);
+ DISALLOW_COPY_AND_ASSIGN(ProximityAuthCryptAuthAccessTokenFetcherTest);
};
-TEST_F(ProximityAuthCryptAuthAccountTokenFetcherTest, FetchSuccess) {
+TEST_F(ProximityAuthCryptAuthAccessTokenFetcherTest, FetchSuccess) {
std::string result;
- fetcher_.FetchAccessToken(base::Bind(SaveAccessToken, &result));
+ fetcher_->FetchAccessToken(base::Bind(SaveAccessToken, &result));
token_service_.IssueAllTokensForAccount(kAccountId, kAccessToken,
base::Time::Max());
EXPECT_EQ(kAccessToken, result);
}
-TEST_F(ProximityAuthCryptAuthAccountTokenFetcherTest, FetchFailure) {
+TEST_F(ProximityAuthCryptAuthAccessTokenFetcherTest, FetchFailure) {
std::string result(kInvalidResult);
- fetcher_.FetchAccessToken(base::Bind(SaveAccessToken, &result));
+ fetcher_->FetchAccessToken(base::Bind(SaveAccessToken, &result));
token_service_.IssueErrorForAllPendingRequestsForAccount(
kAccountId,
GoogleServiceAuthError(GoogleServiceAuthError::SERVICE_ERROR));
@@ -57,13 +58,13 @@ TEST_F(ProximityAuthCryptAuthAccountTokenFetcherTest, FetchFailure) {
EXPECT_EQ(std::string(), result);
}
-TEST_F(ProximityAuthCryptAuthAccountTokenFetcherTest, FetcherReuse) {
+TEST_F(ProximityAuthCryptAuthAccessTokenFetcherTest, FetcherReuse) {
std::string result1;
- fetcher_.FetchAccessToken(base::Bind(SaveAccessToken, &result1));
+ fetcher_->FetchAccessToken(base::Bind(SaveAccessToken, &result1));
{
std::string result2(kInvalidResult);
- fetcher_.FetchAccessToken(base::Bind(SaveAccessToken, &result2));
+ fetcher_->FetchAccessToken(base::Bind(SaveAccessToken, &result2));
EXPECT_EQ(std::string(), result2);
}

Powered by Google App Engine
This is Rietveld 408576698