Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: components/proximity_auth/cryptauth/cryptauth_client_factory.h

Issue 1066453002: Refactor CryptAuth component to be more testable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cryptauth_securemessage
Patch Set: rename tests Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/proximity_auth/cryptauth/cryptauth_client_factory.h
diff --git a/components/proximity_auth/cryptauth/cryptauth_client_factory.h b/components/proximity_auth/cryptauth/cryptauth_client_factory.h
deleted file mode 100644
index c1dc95ba5f65edb61af9d045c46057fed01e563b..0000000000000000000000000000000000000000
--- a/components/proximity_auth/cryptauth/cryptauth_client_factory.h
+++ /dev/null
@@ -1,51 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef COMPONENTS_PROXIMITY_AUTH_CRYPT_AUTH_CLIENT_FACTORY_H
-#define COMPONENTS_PROXIMITY_AUTH_CRYPT_AUTH_CLIENT_FACTORY_H
-
-#include "base/macros.h"
-#include "base/memory/weak_ptr.h"
-#include "components/proximity_auth/cryptauth/cryptauth_client.h"
-#include "components/proximity_auth/cryptauth/proto/cryptauth_api.pb.h"
-#include "google_apis/gaia/oauth2_token_service.h"
-#include "net/url_request/url_request_context_getter.h"
-
-namespace proximity_auth {
-
-class CryptAuthClient;
-
-// Factory for creating CryptAuthClient instances. Because each CryptAuthClient
-// instance can only be used for one API call, this class helps making multiple
-// requests in sequence or parallel easier.
-class CryptAuthClientFactory {
- public:
- // Creates the factory.
- // |token_service|: Gets the user's access token.
- // Needs to outlive this object.
- // |account_id|: The account id of the user.
- // |url_request_context|: The request context to make the HTTP requests.
- // |device_classifier|: Contains basic device information of the client.
- CryptAuthClientFactory(
- OAuth2TokenService* token_service,
- const std::string& account_id,
- scoped_refptr<net::URLRequestContextGetter> url_request_context,
- const cryptauth::DeviceClassifier& device_classifier);
- virtual ~CryptAuthClientFactory();
-
- // Creates and returns a CryptAuthClient instance that is owned by the caller.
- scoped_ptr<CryptAuthClient> CreateInstance();
-
- private:
- OAuth2TokenService* token_service_;
- const std::string account_id_;
- const scoped_refptr<net::URLRequestContextGetter> url_request_context_;
- const cryptauth::DeviceClassifier device_classifier_;
-
- DISALLOW_COPY_AND_ASSIGN(CryptAuthClientFactory);
-};
-
-} // namespace proximity_auth
-
-#endif // COMPONENTS_PROXIMITY_AUTH_CRYPT_AUTH_CLIENT_FACTORY_H

Powered by Google App Engine
This is Rietveld 408576698