Refactor CryptAuth component to be more testable.

components/proximity_auth/cryptauth/cryptauth_access_token_fetcher_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "components/proximity_auth/cryptauth/cryptauth_account_token_fetcher.h"
-
 #include <string>
 
 #include "base/bind.h"
+#include "components/proximity_auth/cryptauth/cryptauth_access_token_fetcher_impl.h"

[Ilya Sherman, 2015/04/06 23:48:02]

nit: The tested header file is supposed to be at the top of unittest files.

[Tim Song, 2015/04/07 02:22:57]

Done.

 #include "google_apis/gaia/fake_oauth2_token_service.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace proximity_auth {
 
 namespace {
 
 const char kAccountId[] = "account_id";
 const char kAccessToken[] = "access_token";
 const char kInvalidResult[] = "invalid_result";
 
 // Callback that saves the fetched access token to the first argument.
 void SaveAccessToken(std::string* out_token, const std::string& in_token) {
   *out_token = in_token;
 }
 
 }  // namespace
 
-class ProximityAuthCryptAuthAccountTokenFetcherTest : public testing::Test {
+class ProximityAuthCryptAuthAccessTokenFetcherTest : public testing::Test {
  protected:
-  ProximityAuthCryptAuthAccountTokenFetcherTest()
-      : fetcher_(&token_service_, kAccountId) {
+  ProximityAuthCryptAuthAccessTokenFetcherTest()
+      : fetcher_(
+            new CryptAuthAccessTokenFetcherImpl(&token_service_, kAccountId)) {
     token_service_.AddAccount(kAccountId);
   }
 
   FakeOAuth2TokenService token_service_;
-  CryptAuthAccountTokenFetcher fetcher_;
+  scoped_ptr<CryptAuthAccessTokenFetcher> fetcher_;

[Ilya Sherman, 2015/04/06 23:48:02]

nit: Does this need to be a scoped_ptr, or can we revert this change?

[Tim Song, 2015/04/07 02:22:57]

Done.

 
-  DISALLOW_COPY_AND_ASSIGN(ProximityAuthCryptAuthAccountTokenFetcherTest);
+  DISALLOW_COPY_AND_ASSIGN(ProximityAuthCryptAuthAccessTokenFetcherTest);
 };
 
-TEST_F(ProximityAuthCryptAuthAccountTokenFetcherTest, FetchSuccess) {
+TEST_F(ProximityAuthCryptAuthAccessTokenFetcherTest, FetchSuccess) {
   std::string result;
-  fetcher_.FetchAccessToken(base::Bind(SaveAccessToken, &result));
+  fetcher_->FetchAccessToken(base::Bind(SaveAccessToken, &result));
   token_service_.IssueAllTokensForAccount(kAccountId, kAccessToken,
                                           base::Time::Max());
 
   EXPECT_EQ(kAccessToken, result);
 }
 
-TEST_F(ProximityAuthCryptAuthAccountTokenFetcherTest, FetchFailure) {
+TEST_F(ProximityAuthCryptAuthAccessTokenFetcherTest, FetchFailure) {
   std::string result(kInvalidResult);
-  fetcher_.FetchAccessToken(base::Bind(SaveAccessToken, &result));
+  fetcher_->FetchAccessToken(base::Bind(SaveAccessToken, &result));
   token_service_.IssueErrorForAllPendingRequestsForAccount(
       kAccountId,
       GoogleServiceAuthError(GoogleServiceAuthError::SERVICE_ERROR));
 
   EXPECT_EQ(std::string(), result);
 }
 
-TEST_F(ProximityAuthCryptAuthAccountTokenFetcherTest, FetcherReuse) {
+TEST_F(ProximityAuthCryptAuthAccessTokenFetcherTest, FetcherReuse) {
   std::string result1;
-  fetcher_.FetchAccessToken(base::Bind(SaveAccessToken, &result1));
+  fetcher_->FetchAccessToken(base::Bind(SaveAccessToken, &result1));
 
   {
     std::string result2(kInvalidResult);
-    fetcher_.FetchAccessToken(base::Bind(SaveAccessToken, &result2));
+    fetcher_->FetchAccessToken(base::Bind(SaveAccessToken, &result2));
     EXPECT_EQ(std::string(), result2);
   }
 
   token_service_.IssueAllTokensForAccount(kAccountId, kAccessToken,
                                           base::Time::Max());
   EXPECT_EQ(kAccessToken, result1);
 }
 
 }  // namespace proximity_auth