Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 106643010: Revert r240528 to reapply r240460; Roll swarm_client @ f89de358c2. (Closed)

Created:
7 years ago by M-A Ruel
Modified:
7 years ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, csharp, ganetsky1, ghost stip (do not use), Nico, Ken Russell (switch to Gerrit)
Visibility:
Public.

Description

Revert r240528 to reapply r240460; Roll swarm_client @ f89de358c2. $ git log aab3a62beb..f89de358c2 --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//' 2013-12-13 maruel Remove the ban on 'command' that are declared in included .isolate file. 2013-12-12 maruel Fix assert occurring on OSX due to already hardlinked files. 2013-12-11 ganetsky Create a .gitignore file and add *.pyc to it 2013-12-11 maruel Stop signalling swarming error on Windows file locking. 2013-12-11 maruel Ensure variables are decoded to unicode. 2013-12-06 maruel Rename --command-variable to --extra-variables. 2013-12-06 maruel Add real variable support and split --variable in 3 different flags. 2013-12-05 vadimsh Add 'offset' parameter to StorageApi.fetch(...) method. 2013-12-05 maruel Change log message to be clearer. 2013-12-05 vadimsh Support custom HTTP headers in net.url_open. 2013-12-03 vadimsh Remove urllib2 support. 2013-12-03 vadimsh Wait for Storage's internal threads to finish before exiting. 2013-12-03 vadimsh Fix swarming_smoke_test.py and isolateserver_test.py. This commit is done manually, as the breakage caused by the last commit can't be tested on the Try Server. This is because of the way build/scripts/slave/runisolatedtest.py modifies the .isolated.state files. R=vadimsh@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240882

Patch Set 1 #

Patch Set 2 : roll at f89de358c2 instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/gtest/setup.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/isolate.gypi View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
This CL depends on https://codereview.chromium.org/101303005/ to be propagated on the "Win Tests *" builders. It ...
7 years ago (2013-12-13 20:13:37 UTC) #1
Vadim Sh.
lgtm
7 years ago (2013-12-13 20:42:09 UTC) #2
M-A Ruel
On 2013/12/13 20:42:09, Vadim Sh. wrote: > lgtm I'll roll to f89de358c2 while at it. ...
7 years ago (2013-12-13 22:13:14 UTC) #3
M-A Ruel
7 years ago (2013-12-16 13:53:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r240882 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698