Improvements in Save password infobar delegate tests.

chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc

Index: chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc
diff --git a/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc b/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc
index 4e9d55d6314147d1d79eec69255786a9a2e6c08e..5a0fb51fddbc8cfef9ac2cd74b36cb6224d7641a 100644
--- a/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc
+++ b/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc
@@ -54,11 +54,11 @@ class SavePasswordInfoBarDelegateTest : public ChromeRenderViewHostTestHarness {
   void TearDown() override;
 
   const autofill::PasswordForm& test_form() { return test_form_; }
-  MockPasswordFormManager* CreateMockFormManager();
+  scoped_ptr<MockPasswordFormManager> CreateMockFormManager();
 
  protected:
   scoped_ptr<ConfirmInfoBarDelegate> CreateDelegate(
-      MockPasswordFormManager* password_form_manager,
+      scoped_ptr<password_manager::PasswordFormManager> password_form_manager,
       password_manager::CredentialSourceType type);
 
   password_manager::StubPasswordManagerClient client_;
@@ -74,20 +74,18 @@ SavePasswordInfoBarDelegateTest::SavePasswordInfoBarDelegateTest() {
   test_form_.password_value = base::ASCIIToUTF16("12345");
 }
 
-MockPasswordFormManager*
+scoped_ptr<MockPasswordFormManager>
 SavePasswordInfoBarDelegateTest::CreateMockFormManager() {
-  return new MockPasswordFormManager(&client_, test_form());
+  return scoped_ptr<MockPasswordFormManager>(
+      new MockPasswordFormManager(&client_, test_form()));
 }
 
 scoped_ptr<ConfirmInfoBarDelegate>
 SavePasswordInfoBarDelegateTest::CreateDelegate(
-    MockPasswordFormManager* password_form_manager,
+    scoped_ptr<password_manager::PasswordFormManager> password_form_manager,
     password_manager::CredentialSourceType type) {
   scoped_ptr<ConfirmInfoBarDelegate> delegate(
-      new TestSavePasswordInfobarDelegate(
-          scoped_ptr<password_manager::PasswordFormManager>(
-              password_form_manager),
-          type));
+      new TestSavePasswordInfobarDelegate(password_form_manager.Pass(), type));
   return delegate.Pass();
 }
 
@@ -100,11 +98,13 @@ void SavePasswordInfoBarDelegateTest::TearDown() {
 }
 
 TEST_F(SavePasswordInfoBarDelegateTest, CancelTestCredentialSourceAPI) {
-  // SavePasswordInfoBarDelegate::Create takes ownership of
-  // password_form_manager_ptr;
-  MockPasswordFormManager* password_form_manager_ptr = CreateMockFormManager();
+  scoped_ptr<MockPasswordFormManager> password_form_manager(
+      CreateMockFormManager());
+  MockPasswordFormManager* password_form_manager_ptr =
+      password_form_manager.get();
+
   scoped_ptr<ConfirmInfoBarDelegate> infobar(CreateDelegate(
-      password_form_manager_ptr,
+      password_form_manager.Pass(),
       password_manager::CredentialSourceType::CREDENTIAL_SOURCE_API));
   EXPECT_CALL(*password_form_manager_ptr, PermanentlyBlacklist())

[vabr (Chromium), 2015/04/08 13:38:08]

nit: Please just inline
*password_form_manager.get()
it is just 2 characters longer than the *_ptr variable.
(Also below.)

       .Times(testing::Exactly(0));
@@ -113,12 +113,14 @@ TEST_F(SavePasswordInfoBarDelegateTest, CancelTestCredentialSourceAPI) {
 
 TEST_F(SavePasswordInfoBarDelegateTest,
        CancelTestCredentialSourcePasswordManager) {
-  // SavePasswordInfoBarDelegate::Create takes ownership of
-  // password_form_manager_ptr;
-  MockPasswordFormManager* password_form_manager_ptr = CreateMockFormManager();
+  scoped_ptr<MockPasswordFormManager> password_form_manager(
+      CreateMockFormManager());
+  MockPasswordFormManager* password_form_manager_ptr =
+      password_form_manager.get();
+
   scoped_ptr<ConfirmInfoBarDelegate> infobar(CreateDelegate(
-      password_form_manager_ptr, password_manager::CredentialSourceType::
-                                     CREDENTIAL_SOURCE_PASSWORD_MANAGER));
+      password_form_manager.Pass(), password_manager::CredentialSourceType::
+                                        CREDENTIAL_SOURCE_PASSWORD_MANAGER));
   EXPECT_CALL(*password_form_manager_ptr, PermanentlyBlacklist())
       .Times(testing::Exactly(1));
   EXPECT_TRUE(infobar->Cancel());