Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1066423002: Improvements in Save password infobar delegate tests. (Closed)

Created:
5 years, 8 months ago by melandory
Modified:
5 years, 8 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improovements in Save password infobar delegate tests. Follow-up CL for https://codereview.chromium.org/1045173003/ BUG=472006 R=vabr@chromium.org Committed: https://crrev.com/4c4145eaf9774ab784de07a3f6abe3b643250160 Cr-Commit-Position: refs/heads/master@{#324390}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -23 lines) Patch
M chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc View 1 3 chunks +18 lines, -22 lines 0 comments Download
M components/password_manager/core/browser/password_manager.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
melandory
5 years, 8 months ago (2015-04-08 12:35:22 UTC) #1
vabr (Chromium)
Thanks, Tanja! You have a tiny typo in the CL description and title (Improovements->Improvements). Otherwise ...
5 years, 8 months ago (2015-04-08 13:38:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066423002/20001
5 years, 8 months ago (2015-04-09 06:41:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-09 07:08:01 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 07:08:59 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c4145eaf9774ab784de07a3f6abe3b643250160
Cr-Commit-Position: refs/heads/master@{#324390}

Powered by Google App Engine
This is Rietveld 408576698