Issue 1066363002: Revert of Fix mips build error 'undefined reference to dlopen'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1066363002: Revert of Fix mips build error 'undefined reference to dlopen' (Closed)

Created:
5 years, 8 months ago by Michael Achenbach

Modified:
5 years, 8 months ago

Reviewers:
pasko, Nico, Xianzhu, carlosk

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Fix mips build error 'undefined reference to dlopen' (patchset #1 id:1 of https://codereview.chromium.org/1056043002/) Reason for revert: Speculative revert. The newest v8 roll might fix the problem. Original issue's description: > Fix mips build error 'undefined reference to dlopen' > > BUG=473473 > TBR=thakis@chromium.org > > Committed: https://crrev.com/89311d3481dc434284972239982a426f8e2154e9 > Cr-Commit-Position: refs/heads/master@{#323734} TBR=carlosk@chromium.org,thakis@chromium.org,pasko@chromium.org,wangxianzhu@chromium.org BUG=473473 Committed: https://crrev.com/15fd4408b5c3314dbce48447d446a3a4dfd9ee87 Cr-Commit-Position: refs/heads/master@{#324207}

Created: 5 years, 8 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	build/common.gypi	View		2 chunks	+1 line, -5 lines	0 comments	Download

Total messages: 5 (1 generated)

Michael Achenbach

Created Revert of Fix mips build error 'undefined reference to dlopen'

5 years, 8 months ago (2015-04-08 07:14:33 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066363002/1

5 years, 8 months ago (2015-04-08 07:15:10 UTC) #3

commit-bot: I haz the power

5 years, 8 months ago (2015-04-08 10:13:11 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/15fd4408b5c3314dbce48447d446a3a4dfd9ee87
Cr-Commit-Position: refs/heads/master@{#324207}