Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1066283002: [Webapp Refactor] Implements remoting.MessageDialog (Closed)

Created:
5 years, 8 months ago by kelvinp
Modified:
5 years, 8 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Webapp Refactor] Implements emoting.MessageDialog This CL implements remoting.MessageBox, a helper class for showing a modal dialog using remoting.setMode() and updates the corresponding call sites to use it. This enables us to show the Me2Me finish dialog from within remoting.Me2MeActivity instead of the global event handlers. In this way, we can move the reconnect after finish logic from remoting.SessionConnector into remoting.Me2MeActivity in a future CL. BUG=474840 NOTRY=true TESTS=All Remoting Webapp Unittests passes and all Chromoting integration test passes https://chromium-swarm.appspot.com/user/task/26b396ab62998910 Committed: https://crrev.com/e474a782678b914c4d4095ee02dd3d693eb79906 Cr-Commit-Position: refs/heads/master@{#324282}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -145 lines) Patch
M remoting/remoting_webapp_files.gypi View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/base/js/input_dialog.js View 1 chunk +0 lines, -93 lines 2 comments Download
A + remoting/webapp/base/js/modal_dialogs.js View 1 chunk +68 lines, -1 line 0 comments Download
M remoting/webapp/crd/js/crd_event_handlers.js View 2 chunks +0 lines, -7 lines 0 comments Download
M remoting/webapp/crd/js/it2me_activity.js View 2 chunks +14 lines, -2 lines 0 comments Download
M remoting/webapp/crd/js/me2me_activity.js View 4 chunks +38 lines, -41 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
kelvinp
PTAL
5 years, 8 months ago (2015-04-08 01:15:56 UTC) #2
Jamie
https://codereview.chromium.org/1066283002/diff/60001/remoting/webapp/base/js/input_dialog.js File remoting/webapp/base/js/input_dialog.js (left): https://codereview.chromium.org/1066283002/diff/60001/remoting/webapp/base/js/input_dialog.js#oldcode93 remoting/webapp/base/js/input_dialog.js:93: })(); Did you intend to remove this? I don't ...
5 years, 8 months ago (2015-04-08 20:07:29 UTC) #6
kelvinp
PTAL https://codereview.chromium.org/1066283002/diff/60001/remoting/webapp/base/js/input_dialog.js File remoting/webapp/base/js/input_dialog.js (left): https://codereview.chromium.org/1066283002/diff/60001/remoting/webapp/base/js/input_dialog.js#oldcode93 remoting/webapp/base/js/input_dialog.js:93: })(); On 2015/04/08 20:07:29, Jamie wrote: > Did ...
5 years, 8 months ago (2015-04-08 20:10:20 UTC) #7
Jamie
lgtm
5 years, 8 months ago (2015-04-08 20:12:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066283002/60001
5 years, 8 months ago (2015-04-08 20:50:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years, 8 months ago (2015-04-08 20:53:35 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 20:55:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e474a782678b914c4d4095ee02dd3d693eb79906
Cr-Commit-Position: refs/heads/master@{#324282}

Powered by Google App Engine
This is Rietveld 408576698