Issue 1066273002: Use SkPictureRecorder::endRecordingAsPicture() instead of endRecording()

Issue 1066273002: Use SkPictureRecorder::endRecordingAsPicture() instead of endRecording() (Closed)

Created:
5 years, 8 months ago by Lei Zhang

Modified:
5 years, 8 months ago

Reviewers:
danakj, mtklein_C, enne (OOO)

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Use SkPictureRecorder::endRecordingAsPicture() instead of endRecording() endRecording() is deprecated. Committed: https://crrev.com/3523bf887df5b18d4837012e2a40e9e509eec409 Cr-Commit-Position: refs/heads/master@{#324260}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -35 lines)			Patch
M	cc/layers/content_layer.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	cc/layers/picture_image_layer.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	cc/layers/picture_layer.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	cc/resources/display_item_list.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	cc/resources/display_item_list_unittest.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	cc/resources/display_list_raster_source.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	cc/resources/gpu_rasterizer.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	cc/resources/picture.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cc/resources/picture_pile_impl.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	cc/resources/skpicture_content_layer_updater.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cc/test/fake_content_layer_client.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	printing/pdf_metafile_skia.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/ext/analysis_canvas_unittest.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	skia/ext/pixel_ref_utils_unittest.cc	View	13 chunks	+23 lines, -13 lines	0 comments	Download

Total messages: 9 (3 generated)

mtklein_C

lgtm (Just so it's clear, this really is just a method rename to have endRecordingAsDrawable() ...

5 years, 8 months ago (2015-04-08 12:01:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066273002/1

5 years, 8 months ago (2015-04-08 17:14:18 UTC) #7

commit-bot: I haz the power

5 years, 8 months ago (2015-04-08 18:50:10 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3523bf887df5b18d4837012e2a40e9e509eec409
Cr-Commit-Position: refs/heads/master@{#324260}