DescriptionAccept non-fatal resource exceptions without generating crash reports.
This adds IsExceptionNonfatalResource() and its test, and uses it in
crashpad_handler. When non-fatal resource exceptions are encountered, no
crash report is generated. crashpad_handler swallows these exceptions.
Alternatively, it could allow them to be sent to the system’s host-level
resource exception handler, normally com.apple.ReportCrash.root, which
would allow them to be processed in the same way as when Crashpad is not
in use. I’m not sure which option is better. I chose to swallow them
because there doesn’t appear to be much value in letting
com.apple.ReportCrash.root and spindump look at them.
This also moves ExcCrashRecoverOriginalException() to the new file as a
sibling of IsExceptionNonfatalResource(). This provides better
organization.
BUG=crashpad:35, chromium:474163, chromium:474326
TEST=crashpad_util_test ExceptionTypes.IsExceptionNonfatalResource
R=rsesek@chromium.org
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/1baff4ff92fe1a1ead6b88b5f01633a4f0b6b51c
Patch Set 1 #Patch Set 2 : --no-find-copies #Patch Set 3 : Use pid_t instead of task_t #Patch Set 4 : Swallow non-fatal EXC_RESOURCE #
Messages
Total messages: 6 (2 generated)
|