gpu: Support parallel active queries in command buffer

gpu: Support parallel active queries in command buffer

Add support for having multiple queries to be active at the same time
given that their targets are different.

BUG=328808
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243524

[jadahl, 2014-01-02 13:58:04]

Hi,

This is a split out of the parallel queries part of
https://codereview.chromium.org/116863003/

The associated bug is http://code.google.com/p/chromium/issues/detail?id=328808
which is a bit related. Should a new bug be created for this type of change?

[reveman, 2014-01-02 15:38:11]

https://codereview.chromium.org/106623008/diff/1/gpu/command_buffer/tests/gl_...
File gpu/command_buffer/tests/gl_query_unittests.cc (right):

https://codereview.chromium.org/106623008/diff/1/gpu/command_buffer/tests/gl_...
gpu/command_buffer/tests/gl_query_unittests.cc:62: // TODO(jadahl): Check
latency result whenever latency test is enabled
Would it be better to use a GL_COMMANDS_ISSUED_CHROMIUM query here? That should
give us a result we can check.

[jadahl, 2014-01-02 15:39:23]

On 2014/01/02 15:38:11, David Reveman wrote:
>
https://codereview.chromium.org/106623008/diff/1/gpu/command_buffer/tests/gl_...
> File gpu/command_buffer/tests/gl_query_unittests.cc (right):
> 
>
https://codereview.chromium.org/106623008/diff/1/gpu/command_buffer/tests/gl_...
> gpu/command_buffer/tests/gl_query_unittests.cc:62: // TODO(jadahl): Check
> latency result whenever latency test is enabled
> Would it be better to use a GL_COMMANDS_ISSUED_CHROMIUM query here? That
should
> give us a result we can check.

I'll give it a try, thanks for the tip.

[jadahl, 2014-01-02 17:51:42]

Uploaded new version which changes the unit test to use
GL_COMMANDS_ISSUED_CHROMIUM instead of the disabled latency test query target.

[reveman, 2014-01-02 17:59:06]

lgtm

[jadahl, 2014-01-03 09:54:50]

On 2014/01/02 17:59:06, David Reveman wrote:
> lgtm

I also need a lgtm from someone in the OWNERS file before continuing, correct?

[reveman, 2014-01-03 18:28:45]

On 2014/01/03 09:54:50, jadahl wrote:
> On 2014/01/02 17:59:06, David Reveman wrote:
> > lgtm
> 
> I also need a lgtm from someone in the OWNERS file before continuing, correct?

yes, piman or sievers should have a look before you land it.

[piman, 2014-01-08 04:22:59]

LGTM, that puts us more in conformance with the spec.

[commit-bot: I haz the power, 2014-01-08 08:51:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jadahl@opera.com/106623008/70001

[commit-bot: I haz the power, 2014-01-08 12:06:20]

Change committed as 243524