Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: runtime/vm/intermediate_language_mips.cc

Issue 106623006: Fix bug in double unboxing. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: fixed mips code Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1727 matching lines...) Expand 10 before | Expand all | Expand 10 after
1738 Register temp = locs()->temp(0).reg(); 1738 Register temp = locs()->temp(0).reg();
1739 Register temp2 = locs()->temp(1).reg(); 1739 Register temp2 = locs()->temp(1).reg();
1740 DRegister fpu_temp = locs()->temp(2).fpu_reg(); 1740 DRegister fpu_temp = locs()->temp(2).fpu_reg();
1741 1741
1742 Label store_pointer, copy_payload; 1742 Label store_pointer, copy_payload;
1743 __ LoadObject(temp, Field::ZoneHandle(field().raw())); 1743 __ LoadObject(temp, Field::ZoneHandle(field().raw()));
1744 __ lw(temp2, FieldAddress(temp, Field::guarded_cid_offset())); 1744 __ lw(temp2, FieldAddress(temp, Field::guarded_cid_offset()));
1745 __ BranchNotEqual(temp2, kDoubleCid, &store_pointer); 1745 __ BranchNotEqual(temp2, kDoubleCid, &store_pointer);
1746 __ lw(temp2, FieldAddress(temp, Field::is_nullable_offset())); 1746 __ lw(temp2, FieldAddress(temp, Field::is_nullable_offset()));
1747 __ BranchEqual(temp2, kNullCid, &store_pointer); 1747 __ BranchEqual(temp2, kNullCid, &store_pointer);
1748 __ lbu(temp2, FieldAddress(temp, Field::kind_bits_offset()));
1749 __ andi(CMPRES1, temp2, Immediate(1 << Field::kUnboxingCandidateBit));
1750 __ beq(CMPRES1, ZR, &store_pointer);
1748 1751
1749 __ lw(temp, FieldAddress(instance_reg, field().Offset())); 1752 __ lw(temp, FieldAddress(instance_reg, field().Offset()));
1750 __ BranchNotEqual(temp, reinterpret_cast<int32_t>(Object::null()), 1753 __ BranchNotEqual(temp, reinterpret_cast<int32_t>(Object::null()),
1751 &copy_payload); 1754 &copy_payload);
1752 1755
1753 StoreInstanceFieldSlowPath* slow_path = 1756 StoreInstanceFieldSlowPath* slow_path =
1754 new StoreInstanceFieldSlowPath(this); 1757 new StoreInstanceFieldSlowPath(this);
1755 compiler->AddSlowPathCode(slow_path); 1758 compiler->AddSlowPathCode(slow_path);
1756 1759
1757 if (!compiler->is_optimizing()) { 1760 if (!compiler->is_optimizing()) {
(...skipping 2420 matching lines...) Expand 10 before | Expand all | Expand 10 after
4178 compiler->GenerateCall(token_pos(), 4181 compiler->GenerateCall(token_pos(),
4179 &label, 4182 &label,
4180 PcDescriptors::kOther, 4183 PcDescriptors::kOther,
4181 locs()); 4184 locs());
4182 __ Drop(2); // Discard type arguments and receiver. 4185 __ Drop(2); // Discard type arguments and receiver.
4183 } 4186 }
4184 4187
4185 } // namespace dart 4188 } // namespace dart
4186 4189
4187 #endif // defined TARGET_ARCH_MIPS 4190 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698