Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1066213002: Fix illegal use of const in container contents to unbreak VS 2015. (Closed)

Created:
5 years, 8 months ago by brucedawson
Modified:
5 years, 8 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix illegal use of const in container contents to unbreak VS 2015. For details see the STL Breaking Changes (VS14 CTP1) section of: http://blogs.msdn.com/b/vcblog/archive/2014/06/06/ c-14-stl-features-fixes-and-breaking-changes-in- visual-studio-14-ctp1.aspx In particular: "The Standard has always forbidden containers of const elements... ...elements must be Assignable, which const T isn't." Error message is: error C2338: The C++ Standard forbids containers of const elements because allocator<const T> is ill-formed. R=cpu@chromium.org BUG=440500 Committed: https://crrev.com/51428030f98124b4ec5d7c16d9b99e13970c2621 Cr-Commit-Position: refs/heads/master@{#324339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M sandbox/win/src/handle_closer.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
brucedawson
5 years, 8 months ago (2015-04-07 21:42:28 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
5 years, 8 months ago (2015-04-09 00:01:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066213002/1
5 years, 8 months ago (2015-04-09 00:03:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 02:12:53 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 02:13:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51428030f98124b4ec5d7c16d9b99e13970c2621
Cr-Commit-Position: refs/heads/master@{#324339}

Powered by Google App Engine
This is Rietveld 408576698