Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1066133002: toolbar: Use a PaintRecorder to access the Canvas for painting. (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
CC:
chromium-reviews, tfarina, enne (OOO), piman, sadrul, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

toolbar: Use a PaintRecorder to access the Canvas for painting. Don't use the canvas() from the PaintContext so that we can have the PaintContext be backed by a DisplayItemList instead in the future. Access to the Canvas should be done through a PaintRecorder. R=pkasting BUG=466426 Committed: https://crrev.com/f072931f978d65c159fa043bf6d2092c25b57724 Cr-Commit-Position: refs/heads/master@{#324128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/views/toolbar/toolbar_action_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danakj
This one's very simple/mechanical.
5 years, 8 months ago (2015-04-07 20:55:10 UTC) #1
Peter Kasting
LGTM
5 years, 8 months ago (2015-04-07 21:24:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066133002/1
5 years, 8 months ago (2015-04-07 21:27:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 21:51:17 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 21:56:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f072931f978d65c159fa043bf6d2092c25b57724
Cr-Commit-Position: refs/heads/master@{#324128}

Powered by Google App Engine
This is Rietveld 408576698