Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1066113002: chromeos: Use a PaintRecorder to access the Canvas for painting. (Closed)

Created:
5 years, 8 months ago by danakj
Modified:
5 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, je_julie(Not used), oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, enne (OOO), piman, sadrul, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Use a PaintRecorder to access the Canvas for painting. Don't use the canvas() from the PaintContext so that we can have the PaintContext be backed by a DisplayItemList instead in the future. Access to the Canvas should be done through a PaintRecorder. R=oshima BUG=466426 Committed: https://crrev.com/a91b108ddfd16dcd539008917ea56d89cb7744cb Cr-Commit-Position: refs/heads/master@{#324115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M chrome/browser/chromeos/display/overscan_calibrator.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/ui/focus_ring_layer.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
danakj
5 years, 8 months ago (2015-04-07 20:30:57 UTC) #1
oshima
lgtm
5 years, 8 months ago (2015-04-07 20:32:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066113002/1
5 years, 8 months ago (2015-04-07 20:44:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 20:59:22 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 21:00:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a91b108ddfd16dcd539008917ea56d89cb7744cb
Cr-Commit-Position: refs/heads/master@{#324115}

Powered by Google App Engine
This is Rietveld 408576698