Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 1066103002: Removed CRWJSEarlyScriptManager from web/ public interface. (Closed)

Created:
5 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
5 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed CRWJSEarlyScriptManager from web/ public interface. BUG=449203 Committed: https://crrev.com/c2a25a37f87ab06abcc2d2ccfe4dfa04a7749527 Cr-Commit-Position: refs/heads/master@{#324254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -25 lines) Patch
M ios/web/ios_web.gyp View 2 chunks +1 line, -1 line 0 comments Download
D ios/web/public/web_state/js/crw_js_early_script_manager.h View 1 chunk +0 lines, -18 lines 0 comments Download
A + ios/web/web_state/js/crw_js_early_script_manager.h View 1 chunk +3 lines, -5 lines 0 comments Download
M ios/web/web_state/js/crw_js_early_script_manager.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Eugene But (OOO till 7-30)
5 years, 8 months ago (2015-04-07 20:27:26 UTC) #2
sdefresne
lgtm
5 years, 8 months ago (2015-04-08 17:10:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066103002/1
5 years, 8 months ago (2015-04-08 17:35:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 18:33:52 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 18:34:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2a25a37f87ab06abcc2d2ccfe4dfa04a7749527
Cr-Commit-Position: refs/heads/master@{#324254}

Powered by Google App Engine
This is Rietveld 408576698