Test gpu memory buffers drawing directly to the backbuffer.

Test gpu memory buffers drawing directly to the backbuffer.

To test the lifecycle of a memory buffer we used to use
glCopyTextureCHROMIUM. This has some limitations due to the extension
spec (i.e: limited subset of formats), and doesn't test the general
lifecycle of the memory buffer.

This patch changes GpuMemoryBufferTest.Lifecycle to test the lifecycle
of the GpuMemoryBuffer writing directly to the backbuffer.

BUG=

Committed: https://crrev.com/af2cc1710b7cb58c990f0a5d7c2841125a84da81
Cr-Commit-Position: refs/heads/master@{#324123}

[Daniele Castagna, 2015-04-07 20:03:51]

dcastagna@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2015-04-07 20:10:19]

lgtm with nits

https://codereview.chromium.org/1066073002/diff/1/gpu/command_buffer/tests/gl...
File gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc (left):

https://codereview.chromium.org/1066073002/diff/1/gpu/command_buffer/tests/gl...
gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc:203: // Destroy the
image.
nit: maybe improve the cleanup in a different patch instead

https://codereview.chromium.org/1066073002/diff/1/gpu/command_buffer/tests/gl...
File gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc (right):

https://codereview.chromium.org/1066073002/diff/1/gpu/command_buffer/tests/gl...
gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc:159:
glActiveTexture(GL_TEXTURE0);
nit: unnecessary

[Daniele Castagna, 2015-04-07 20:15:53]

https://codereview.chromium.org/1066073002/diff/1/gpu/command_buffer/tests/gl...
File gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc (left):

https://codereview.chromium.org/1066073002/diff/1/gpu/command_buffer/tests/gl...
gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc:203: // Destroy the
image.
On 2015/04/07 at 20:10:19, reveman wrote:
> nit: maybe improve the cleanup in a different patch instead

The clean up works now.

https://codereview.chromium.org/1066073002/diff/1/gpu/command_buffer/tests/gl...
File gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc (right):

https://codereview.chromium.org/1066073002/diff/1/gpu/command_buffer/tests/gl...
gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc:159:
glActiveTexture(GL_TEXTURE0);
On 2015/04/07 at 20:10:19, reveman wrote:
> nit: unnecessary

Done.

[Daniele Castagna, 2015-04-07 20:23:30]

dcastagna@chromium.org changed reviewers:
+ piman@chromium.org

[Daniele Castagna, 2015-04-07 20:23:31]

+piman@ for owner approval.

[piman, 2015-04-07 20:55:56]

lgtm

https://codereview.chromium.org/1066073002/diff/20001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc (right):

https://codereview.chromium.org/1066073002/diff/20001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc:41: auto options =
GLManager::Options();
nit: GLManager::Options options;

[Daniele Castagna, 2015-04-07 21:02:57]

https://codereview.chromium.org/1066073002/diff/20001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc (right):

https://codereview.chromium.org/1066073002/diff/20001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc:41: auto options =
GLManager::Options();
On 2015/04/07 at 20:55:56, piman (Very slow to review) wrote:
> nit: GLManager::Options options;

Done.

[Daniele Castagna, 2015-04-07 21:03:08]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2015-04-07 21:03:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1066073002/#ps40001
(title: "Address piman's comment.")

[commit-bot: I haz the power, 2015-04-07 21:03:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1066073002/40001

[commit-bot: I haz the power, 2015-04-07 21:35:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-07 21:35:56]

Patchset 3 (id:??) landed as
https://crrev.com/af2cc1710b7cb58c990f0a5d7c2841125a84da81
Cr-Commit-Position: refs/heads/master@{#324123}