android_webview/java/src/org/chromium/android_webview/AwContentsClient.java - Issue 1066053002: [Android] Allow custom ActionMode creation via ContentViewClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Issue 1066053002: [Android] Allow custom ActionMode creation via ContentViewClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix null check Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java ('k') | android_webview/test/shell/src/org/chromium/android_webview/test/NullContentsClient.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

index 52fbcc3f784406573426c352d21901855f64f560..5a07dc8740f2f8415d6974f333c33e77bbfa58d1 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

@@ -22,6 +22,8 @@ import android.webkit.WebChromeClient;

import org.chromium.android_webview.permission.AwPermissionRequest;

import org.chromium.base.annotations.SuppressFBWarnings;

+import org.chromium.content.browser.SelectActionMode;

+import org.chromium.content.browser.SelectActionModeCallback.ActionHandler;

import java.security.Principal;

import java.util.HashMap;

@@ -318,4 +320,8 @@ public abstract class AwContentsClient {

public abstract void onNewPicture(Picture picture);

+ public abstract SelectActionMode startActionMode(

+ View view, ActionHandler actionHandler, boolean floating);

+ public abstract boolean supportsFloatingActionMode();

}