Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1066013003: Revert of Upstream string_util function. (Closed)

Created:
5 years, 8 months ago by Mark P
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Upstream string_util function. (patchset #4 id:60001 of https://codereview.chromium.org/1073863005/) Reason for revert: Causes checkdeps failures: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/23234/steps/checkdeps/logs/stdio ERROR in /mnt/data/b/build/slave/Linux_Tests/build/src/ios/chrome/test/ios_chrome_unit_test_suite.cc Illegal include: "ios/public/test/test_chrome_browser_provider.h" Because of "-ios" from ios's include_rules. Illegal include: "ios/public/test/test_chrome_provider_initializer.h" Because of "-ios" from ios's include_rules. Illegal include: "ios/web/public/web_client.h" Because of "-ios" from ios's include_rules. Illegal include: "ui/base/ui_base_paths.h" Because of no rule applying. ERROR in /mnt/data/b/build/slave/Linux_Tests/build/src/ios/chrome/test/testing_application_context.cc Illegal include: "ios/public/provider/chrome/browser/chrome_browser_provider.h" Because of "-ios" from ios's include_rules. FAILED Original issue's description: > Upstream string_util function. > > Create ios/chrome/common as these functions may be needed by external components. > > Narrowing DEPS from ios/chrome to ios/chrome/browser. > > TBR=mef, sdefresne,rsesek, thakis > > Committed: https://crrev.com/09508e0b6219f0febf9a609e1c9ff6d6eb6dde8e > Cr-Commit-Position: refs/heads/master@{#324860} TBR=sdefresne@chromium.org,droger@chromium.org,thakis@chromium.org,rsesek@chromium.org,mef@chromium.org,olivierrobin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/525b51d20d0249a559ab791d01e464ba3e43dae6 Cr-Commit-Position: refs/heads/master@{#324877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -345 lines) Patch
M ios/chrome/DEPS View 1 chunk +32 lines, -0 lines 0 comments Download
D ios/chrome/browser/DEPS View 1 chunk +0 lines, -34 lines 0 comments Download
D ios/chrome/common/README.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D ios/chrome/common/string_util.h View 1 chunk +0 lines, -44 lines 0 comments Download
D ios/chrome/common/string_util.mm View 1 chunk +0 lines, -184 lines 0 comments Download
D ios/chrome/common/string_util_unittest.mm View 1 chunk +0 lines, -58 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 2 chunks +0 lines, -21 lines 0 comments Download
M ios/chrome/ios_chrome_tests.gyp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark P
Created Revert of Upstream string_util function.
5 years, 8 months ago (2015-04-13 17:39:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066013003/1
5 years, 8 months ago (2015-04-13 17:40:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-13 17:43:10 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 17:44:48 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/525b51d20d0249a559ab791d01e464ba3e43dae6
Cr-Commit-Position: refs/heads/master@{#324877}

Powered by Google App Engine
This is Rietveld 408576698