Make sure builtins preserve guarantees about empty element array prototypes.

Make sure builtins preserve guarantees about empty element array prototypes.

We have a bottleneck around storing elements in the array and object prototypes,
but the Push() and Unshift() builtins don't respect them.

Fix this exactly to the level of existing support for stores.

BUG=v8:4043
LOG=N
NOTRY=true

Committed: https://crrev.com/9987221c02b63bb93c6013e9706bd5e93322ef14
Cr-Commit-Position: refs/heads/master@{#27943}

[mvstanton, 2015-04-20 10:34:33]

mvstanton@chromium.org changed reviewers:
+ jkummerow@chromium.org

[mvstanton, 2015-04-20 10:34:34]

Hi Jakob, here is the CL we discussed, thx for the look.
--Michael

[Jakob Kummerow, 2015-04-20 10:52:05]

LGTM with nits.

https://codereview.chromium.org/1066003003/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1066003003/diff/20001/src/objects.cc#newcode1...
src/objects.cc:12748: PrintF("Deopting\n");
debugging leftover?

https://codereview.chromium.org/1066003003/diff/20001/test/mjsunit/elide-doub...
File test/mjsunit/elide-double-hole-check-10.js (right):

https://codereview.chromium.org/1066003003/diff/20001/test/mjsunit/elide-doub...
test/mjsunit/elide-double-hole-check-10.js:34: %OptimizeFunctionOnNextCall(foo);
nit: indentation

[mvstanton, 2015-04-20 11:02:40]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-04-20 11:02:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1066003003/#ps60001
(title: "REBASE, fix nits.")

[commit-bot: I haz the power, 2015-04-20 11:02:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1066003003/60001

[commit-bot: I haz the power, 2015-04-20 11:39:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-20 11:39:20]

Try jobs failed on following builders:
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/5016)

[Michael Achenbach, 2015-04-20 12:10:42]

You can retry with NOTRY=true for now.

[mvstanton, 2015-04-20 13:57:53]

The CQ bit was checked by mvstanton@chromium.org

[commit-bot: I haz the power, 2015-04-20 13:58:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1066003003/60001

[mvstanton, 2015-04-20 14:10:39]

Thanks Jakob, nits addressed...

https://codereview.chromium.org/1066003003/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1066003003/diff/20001/src/objects.cc#newcode1...
src/objects.cc:12748: PrintF("Deopting\n");
On 2015/04/20 10:52:05, Jakob wrote:
> debugging leftover?

Done.

https://codereview.chromium.org/1066003003/diff/20001/test/mjsunit/elide-doub...
File test/mjsunit/elide-double-hole-check-10.js (right):

https://codereview.chromium.org/1066003003/diff/20001/test/mjsunit/elide-doub...
test/mjsunit/elide-double-hole-check-10.js:34: %OptimizeFunctionOnNextCall(foo);
On 2015/04/20 10:52:05, Jakob wrote:
> nit: indentation

Done.

[commit-bot: I haz the power, 2015-04-20 15:16:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-20 15:17:02]

Patchset 4 (id:??) landed as
https://crrev.com/9987221c02b63bb93c6013e9706bd5e93322ef14
Cr-Commit-Position: refs/heads/master@{#27943}