Introduce "expression classifier" to the parser.

Introduce "expression classifier" to the parser.

R=marja@chromium.org,rossberg@chromium.org

Committed: https://crrev.com/f3ee83b63142aad78a71ebd83b3abc463ea60612
Cr-Commit-Position: refs/heads/master@{#28005}

[Dmitry Lomov (no reviews), 2015-04-21 16:47:41]

PTAL - this is a very mechanical CL, just adding an extra parameter to all
expression-parsing methods.

[marja, 2015-04-21 19:45:15]

I'm missing some context here... what's the context?

[Dmitry Lomov (no reviews), 2015-04-21 19:47:20]

On 2015/04/21 19:45:15, marja wrote:
> I'm missing some context here... what's the context?

See design doc (it was a year ago, you have probably forgotten all about it):

https://docs.google.com/document/d/1iJWvuakeKsPJOeA-RJ-4bM3Jha5iewQjxKsylgzHE...

Patterns are (almost) a subset of expressions in terms of grammar, and we need
to parse them simultaneously and distunguish.

[marja, 2015-04-21 20:04:46]

lgtm

[rossberg, 2015-04-22 09:30:47]

https://codereview.chromium.org/1065983005/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1065983005/diff/1/src/preparser.h#newcode578
src/preparser.h:578: class ExpressionClassifier {
Don't we also want is_valid_arrow_parameter_list, to generalise the current
hacks around that?

https://codereview.chromium.org/1065983005/diff/1/src/preparser.h#newcode2028
src/preparser.h:2028: #define CHECK_CLASSIFIER_OK  classifier, ok); \
Don't think this macro is worth it. It saves a single character, which doesn't
justify the added obscurity and irregularity...

Unless you plan to merge the ok into the classifier. Not sure if that's
desirable?

[Dmitry Lomov (no reviews), 2015-04-22 09:36:55]

https://codereview.chromium.org/1065983005/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/1065983005/diff/1/src/preparser.h#newcode578
src/preparser.h:578: class ExpressionClassifier {
On 2015/04/22 09:30:47, rossberg wrote:
> Don't we also want is_valid_arrow_parameter_list, to generalise the current
> hacks around that?

Sounds good, but I'd prefer to do that in a separate CL.

https://codereview.chromium.org/1065983005/diff/1/src/preparser.h#newcode2028
src/preparser.h:2028: #define CHECK_CLASSIFIER_OK  classifier, ok); \
On 2015/04/22 09:30:47, rossberg wrote:
> Don't think this macro is worth it. It saves a single character, which doesn't
> justify the added obscurity and irregularity...
> 
> Unless you plan to merge the ok into the classifier. Not sure if that's
> desirable?

Yes, I think we should merge ok into a classifier - does not make sense to have
both. But I'd perfer to do that in a separate CL as well.

[Dmitry Lomov (no reviews), 2015-04-22 09:59:08]

Removed CHECK_CLASSIFIER_OK macro

[rossberg, 2015-04-22 10:39:36]

lgtm

[Dmitry Lomov (no reviews), 2015-04-22 10:45:59]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-04-22 10:45:59]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org
Link to the patchset: https://codereview.chromium.org/1065983005/#ps20001
(title: "CR feedback")

[commit-bot: I haz the power, 2015-04-22 10:46:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1065983005/20001

[commit-bot: I haz the power, 2015-04-22 10:47:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-22 10:47:45]

Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/5043)

[Dmitry Lomov (no reviews), 2015-04-22 11:15:17]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-04-22 11:15:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org, marja@chromium.org
Link to the patchset: https://codereview.chromium.org/1065983005/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2015-04-22 11:15:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1065983005/40001

[commit-bot: I haz the power, 2015-04-22 11:16:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-22 11:16:46]

Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/5045)

[Dmitry Lomov (no reviews), 2015-04-22 11:44:50]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-04-22 11:44:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org, marja@chromium.org
Link to the patchset: https://codereview.chromium.org/1065983005/#ps60001
(title: "One more rebase")

[commit-bot: I haz the power, 2015-04-22 11:44:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1065983005/60001

[commit-bot: I haz the power, 2015-04-22 11:52:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-22 11:52:59]

Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[Dmitry Lomov (no reviews), 2015-04-22 12:08:33]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-04-22 12:08:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org, marja@chromium.org
Link to the patchset: https://codereview.chromium.org/1065983005/#ps80001
(title: "Added operator== and operator!= to Scanner::Location")

[commit-bot: I haz the power, 2015-04-22 12:08:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1065983005/80001

[commit-bot: I haz the power, 2015-04-22 12:35:10]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-22 13:19:37]

Patchset 5 (id:??) landed as
https://crrev.com/f3ee83b63142aad78a71ebd83b3abc463ea60612
Cr-Commit-Position: refs/heads/master@{#28005}