Add utime implementation to libnacl

tests/syscalls/syscalls.cc

 /*
  * Copyright (c) 2011 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * NaCl tests for simple syscalls
  */
 
 #include <dirent.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <limits.h>
 #include <sched.h>
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
 #include <unistd.h>
+#include <utime.h>
 
 #include "native_client/src/include/nacl_assert.h"
 #include "native_client/src/trusted/service_runtime/include/sys/nacl_syscalls.h"
 #include "native_client/src/trusted/service_runtime/nacl_config.h"
 
 #define PRINT_HEADER 0
 #define TEXT_LINE_SIZE 1024
 
 /*
- * TODO(sbc): remove this test once these declarations get added to the prebuilt
+ * TODO(sbc): remove this test once these declarations get added to the
  * newlib toolchain
  */
 #ifndef __GLIBC__
-extern "C" int gethostname(char *name, size_t len);
-extern "C" int utimes(const char *filename, const struct timeval times[2]);
-extern "C" int eaccess(const char *pathname, int mode);
+extern "C" {
+int gethostname(char *name, size_t len);
+int utimes(const char *filename, const struct timeval times[2]);
+int utime(const char *filename, const struct utimbuf *times);
+int eaccess(const char *pathname, int mode);
+}
 #endif
 
 /*
  * function failed(testname, msg)
  *   print failure message and exit with a return code of -1
  */
 bool failed(const char *testname, const char *msg) {
   printf("TEST FAILED: %s: %s\n", testname, msg);
   return false;
 }
@@ skipping 422 matching lines @@
   if (NONSFI_MODE)
     return true;
   struct timeval times[2];
   // utimes() is currently not implemented and should always
   // fail with ENOSYS
   ASSERT_EQ(utimes("dummy", times), -1);
   ASSERT_EQ(errno, ENOSYS);
   return passed("test_utimes", "all");
 }
 
+bool test_utime(const char *test_file) {
+  // TODO(mseaborn): Implement utimes for unsandboxed mode.
+  if (NONSFI_MODE)
+    return true;
+  printf("test_utime");
+  struct utimbuf times;
+  times.actime = 0;
+  times.modtime = 0;
+  // utimes() is currently not implemented and should always
+  // fail with ENOSYS
+  printf("test_utime 2");
+
+  ASSERT_EQ(utime("dummy", &times), -1);
+  ASSERT_EQ(errno, ENOSYS);
+  return passed("test_utime", "all");
+}
+
 bool test_truncate(const char *test_file) {
   char temp_file[PATH_MAX];
   snprintf(temp_file, PATH_MAX, "%s.tmp_truncate", test_file);
 
   char buffer[100];
   char read_buffer[200];
   struct stat buf;
   for (size_t i = 0; i < sizeof(buffer); i++)
     buffer[i] = i;
 
@@ skipping 581 matching lines @@
   ret &= test_symlinks(test_file);
   ret &= test_chmod(test_file);
   ret &= test_access(test_file);
 #endif
 // TODO(sbc): remove this restriction once glibc's truncate calls
 // is hooked up to the IRT dev-filename-0.2 interface:
 // https://code.google.com/p/nativeclient/issues/detail?id=3709
 #if !defined(__GLIBC__)
   ret &= test_truncate(test_file);
 #endif
+  ret &= test_utime(test_file);

[Mark Seaborn, 2015/04/07 19:08:43]

Nit: Put after test_utimes() to match the definitions

[Sam Clegg, 2015/04/10 21:18:56]

Done.

   ret &= test_utimes(test_file);
   return ret;
 }
 
 /*
  * main entry point.
  *
  * run all tests and call system exit with appropriate value
  *   0 - success, all tests passed.
  *  -1 - one or more tests failed.
@@ skipping 10 matching lines @@
   passed = testSuite(argv[1]);
 
   if (passed) {
     printf("All tests PASSED\n");
     exit(0);
   } else {
     printf("One or more tests FAILED\n");
     exit(-1);
   }
 }