Add utime implementation to libnacl

src/untrusted/nacl/sys_private.c

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * This file defines various POSIX-like functions directly using NaCl
  * syscall trampolines.  For normal application use, these are defined
  * instead using the IRT function tables.  Here we're defining the versions
  * to be used inside the IRT itself, and in various local tests that do not
  * use the IRT.
  *
  * We define these all in one file so that we can be sure that we get
  * them all defined here and won't have any stragglers brought in from
  * the normal C libraries, where we'd get the IRT-based versions instead.
  * Since the first thing in the link (../stubs/crt1.x) forces a reference
  * to _exit, we can be sure that this file will be brought in first.
  */
 
 #include <errno.h>
 #include <fcntl.h>
 #include <sched.h>
 #include <stdarg.h>
 #include <stdint.h>
+#include <sys/mman.h>
+#include <sys/types.h>
 #include <time.h>
 #include <unistd.h>
-#include <sys/types.h>
-#include <sys/mman.h>
+#include <utime.h>
 
 #include "native_client/src/include/elf32.h"
 #include "native_client/src/untrusted/nacl/getcwd.h"
 #include "native_client/src/untrusted/nacl/syscall_bindings_trampoline.h"
 
 struct dirent;
 struct stat;
 struct timeval;
 struct timespec;
 
@@ skipping 205 matching lines @@
 }
 
 int access(const char *path, int amode) {
   return errno_call(NACL_SYSCALL(access)(path, amode));
 }
 
 int readlink(const char *path, char *buf, int bufsize) {
   return errno_value_call(NACL_SYSCALL(readlink)(path, buf, bufsize));
 }
 
+int utime(const char *path, const struct utimbuf *buf) {

[Mark Seaborn, 2015/04/07 19:08:43]

If utime.c calls utimes(), you don't need this here.

[Sam Clegg, 2015/04/10 21:18:55]

Good idea.  Done.

+  struct timeval times[2];
+  struct timeval* tv = NULL;

[Mark Seaborn, 2015/04/07 19:08:43]

Use " *" spacing

[Sam Clegg, 2015/04/10 21:18:55]

Acknowledged.

+  if (buf != NULL) {
+    times[0].tv_sec = buf->actime;
+    times[1].tv_sec = buf->modtime;
+    times[0].tv_usec = 0;
+    times[1].tv_usec = 0;
+    tv = times;
+  }
+  return errno_value_call(NACL_SYSCALL(utimes)(path, tv));
+}
+
 int utimes(const char *path, const struct timeval times[2]) {
   return errno_value_call(NACL_SYSCALL(utimes)(path, times));
 }
 
 /*
  * This is a stub since _start will call it but we don't want to
  * do the normal initialization.
  */
 void __libnacl_irt_init(Elf32_auxv_t *auxv) {
 }
 
 /*
  * These have to be weak because the IRT defines its own versions.
  */
 __attribute__((weak)) int nacl_tls_init(void *thread_ptr) {
   return -NACL_SYSCALL(tls_init)(thread_ptr);
 }
 
 __attribute__((weak)) void *nacl_tls_get(void) {
   return NACL_SYSCALL(tls_get)();
 }