runtime/vm/instructions_x64_test.cc - Issue 106593002: Write protect executable pages in the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/instructions_x64_test.cc

Issue 106593002: Write protect executable pages in the VM. Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/instructions_x64_test.cc

diff --git a/runtime/vm/instructions_x64_test.cc b/runtime/vm/instructions_x64_test.cc

index c9abf0f1774c713f1776171fb7420a46439f270b..cecc2778825f2f622715cf37dbfc21083d303871 100644

--- a/runtime/vm/instructions_x64_test.cc

+++ b/runtime/vm/instructions_x64_test.cc

@@ -44,6 +44,13 @@ ASSEMBLER_TEST_GENERATE(Jump, assembler) {

ASSEMBLER_TEST_RUN(Jump, test) {

ASSERT(prologue_code_size != -1);

+ const Code& code = test->code();

+ const Instructions& instrs = Instructions::Handle(code.instructions());

+ bool status =

+ VirtualMemory::Protect(reinterpret_cast<void*>(instrs.EntryPoint()),

+ instrs.size(),

+ VirtualMemory::kReadWriteExecute);

+ EXPECT(status);

JumpPattern jump1(test->entry() + prologue_code_size, test->code());

jump1.IsValid();

EXPECT_EQ(StubCode::InstanceFunctionLookupLabel().address(),

« no previous file with comments | « runtime/vm/instructions_mips_test.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »