Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1065923002: [turbofan] Add JSStackCheck into loop bodies. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 8 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-toplevel
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add JSStackCheck into loop bodies. This allows loopy TurboFan code to be interrupted by placing a stack check (i.e. JSStackCheck node) into each loop. Note that we currently limit this to non-asm.js code. Also note that stack checks are actually placed after loop headers and not at back-branches, which allows us to reuse existing BailoutIds from Crankshaft. R=titzer@chromium.org Committed: https://crrev.com/322cfb3589bc122e773fef041254ded514b31b8e Cr-Commit-Position: refs/heads/master@{#27666}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M src/compiler.cc View 2 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 7 chunks +0 lines, -7 lines 0 comments Download
M test/cctest/test-debug.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-thread-termination.cc View 5 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 8 months ago (2015-04-07 14:03:56 UTC) #1
titzer
lgtm
5 years, 8 months ago (2015-04-08 09:53:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065923002/40001
5 years, 8 months ago (2015-04-08 12:24:05 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-08 12:55:02 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 12:55:10 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/322cfb3589bc122e773fef041254ded514b31b8e
Cr-Commit-Position: refs/heads/master@{#27666}

Powered by Google App Engine
This is Rietveld 408576698