Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1065893003: X87: Change near dump to far jump to fix the jump distance check error. (Closed)

Created:
5 years, 8 months ago by chunyang.dai
Modified:
5 years, 8 months ago
Reviewers:
Weiliang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Change near jump to far jump to fix the jump distance check error. The assembler code generated by the DeoptimizeIf(...) function under X87 is larger and the distance between the link point and the bind point which has two DeoptimizeIf() is larger then near link distance (127) for labels. BUG= Committed: https://crrev.com/fc6e6234254e8ea44087502ac5742ad0c1d55bcf Cr-Commit-Position: refs/heads/master@{#27801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/x87/lithium-codegen-x87.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 8 months ago (2015-04-13 17:08:07 UTC) #2
Weiliang
lgtm
5 years, 8 months ago (2015-04-14 01:32:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065893003/1
5 years, 8 months ago (2015-04-14 01:32:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 02:09:21 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 02:09:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc6e6234254e8ea44087502ac5742ad0c1d55bcf
Cr-Commit-Position: refs/heads/master@{#27801}

Powered by Google App Engine
This is Rietveld 408576698