Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1065873004: Updated the <webview> loadabort documentatin with the actual "reason" strings that are currently us… (Closed)

Created:
5 years, 8 months ago by paulmeyer
Modified:
5 years, 8 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated the <webview> loadabort documentatin with the actual "reason" strings that are currently used. BUG=470479 Committed: https://crrev.com/d497f00129fdad062e37eaf5726edda76b2bd212 Cr-Commit-Position: refs/heads/master@{#325239}

Patch Set 1 #

Patch Set 2 : Rebased; Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/common/extensions/api/webview_tag.json View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
paulmeyer
+lazyboy@
5 years, 8 months ago (2015-04-14 20:33:05 UTC) #2
lazyboy
Thanks for fixing this. Although this is not the whole set e.reason can take, there ...
5 years, 8 months ago (2015-04-15 01:58:45 UTC) #3
paulmeyer
On 2015/04/15 01:58:45, lazyboy wrote: > Thanks for fixing this. > > Although this is ...
5 years, 8 months ago (2015-04-15 12:27:00 UTC) #4
lazyboy
On 2015/04/15 12:27:00, Paul Meyer wrote: > On 2015/04/15 01:58:45, lazyboy wrote: > > Thanks ...
5 years, 8 months ago (2015-04-15 12:34:18 UTC) #5
paulmeyer
On 2015/04/15 12:34:18, lazyboy wrote: > On 2015/04/15 12:27:00, Paul Meyer wrote: > > On ...
5 years, 8 months ago (2015-04-15 13:40:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065873004/20001
5 years, 8 months ago (2015-04-15 13:41:06 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 14:04:33 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 14:05:22 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d497f00129fdad062e37eaf5726edda76b2bd212
Cr-Commit-Position: refs/heads/master@{#325239}

Powered by Google App Engine
This is Rietveld 408576698