Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/harmony-tostring.js

Issue 1065863003: Use array literals instead of array constructor in native javascript. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase and fix Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/harmony-reflect.js ('k') | src/harmony-typedarray.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 "use strict"; 5 "use strict";
6 6
7 // This file relies on the fact that the following declaration has been made 7 // This file relies on the fact that the following declaration has been made
8 // in runtime.js and symbol.js: 8 // in runtime.js and symbol.js:
9 // var $Object = global.Object; 9 // var $Object = global.Object;
10 10
11 DefaultObjectToString = ObjectToStringHarmony; 11 DefaultObjectToString = ObjectToStringHarmony;
12 // ES6 draft 08-24-14, section 19.1.3.6 12 // ES6 draft 08-24-14, section 19.1.3.6
13 function ObjectToStringHarmony() { 13 function ObjectToStringHarmony() {
14 if (IS_UNDEFINED(this) && !IS_UNDETECTABLE(this)) return "[object Undefined]"; 14 if (IS_UNDEFINED(this) && !IS_UNDETECTABLE(this)) return "[object Undefined]";
15 if (IS_NULL(this)) return "[object Null]"; 15 if (IS_NULL(this)) return "[object Null]";
16 var O = ToObject(this); 16 var O = ToObject(this);
17 var builtinTag = %_ClassOf(O); 17 var builtinTag = %_ClassOf(O);
18 var tag = O[symbolToStringTag]; 18 var tag = O[symbolToStringTag];
19 if (!IS_STRING(tag)) { 19 if (!IS_STRING(tag)) {
20 tag = builtinTag; 20 tag = builtinTag;
21 } 21 }
22 return "[object " + tag + "]"; 22 return "[object " + tag + "]";
23 } 23 }
24 24
25 function HarmonyToStringExtendSymbolPrototype() { 25 function HarmonyToStringExtendSymbolPrototype() {
26 %CheckIsBootstrapping(); 26 %CheckIsBootstrapping();
27 27
28 InstallConstants(global.Symbol, $Array( 28 InstallConstants(global.Symbol, [
29 // TODO(dslomov, caitp): Move to symbol.js when shipping 29 // TODO(dslomov, caitp): Move to symbol.js when shipping
30 "toStringTag", symbolToStringTag 30 "toStringTag", symbolToStringTag
31 )); 31 ]);
32 } 32 }
33 33
34 HarmonyToStringExtendSymbolPrototype(); 34 HarmonyToStringExtendSymbolPrototype();
OLDNEW
« no previous file with comments | « src/harmony-reflect.js ('k') | src/harmony-typedarray.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698