Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1065863003: Use array literals instead of array constructor in native javascript. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use array literals instead of array constructor in native javascript. R=jkummerow@chromium.org Committed: https://crrev.com/fc0dec31c0633a4ca28d918d00852f915cf6ba28 Cr-Commit-Position: refs/heads/master@{#27760}

Patch Set 1 #

Patch Set 2 : rebase and fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -254 lines) Patch
M src/array.js View 1 3 chunks +8 lines, -8 lines 0 comments Download
M src/array-iterator.js View 2 chunks +4 lines, -4 lines 0 comments Download
M src/arraybuffer.js View 1 1 chunk +6 lines, -6 lines 0 comments Download
M src/collection.js View 2 chunks +4 lines, -4 lines 0 comments Download
M src/collection-iterator.js View 4 chunks +8 lines, -8 lines 0 comments Download
M src/date.js View 3 chunks +5 lines, -5 lines 0 comments Download
M src/harmony-array.js View 2 chunks +7 lines, -7 lines 0 comments Download
M src/harmony-array-includes.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/harmony-reflect.js View 1 chunk +4 lines, -4 lines 0 comments Download
M src/harmony-tostring.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/harmony-typedarray.js View 1 chunk +4 lines, -4 lines 0 comments Download
M src/json.js View 3 chunks +4 lines, -4 lines 0 comments Download
M src/math.js View 4 chunks +4 lines, -5 lines 0 comments Download
M src/messages.js View 1 6 chunks +16 lines, -13 lines 0 comments Download
M src/object-observe.js View 1 chunk +6 lines, -6 lines 0 comments Download
M src/regexp.js View 2 chunks +2 lines, -3 lines 0 comments Download
M src/snapshot/serialize.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/string.js View 1 3 chunks +4 lines, -5 lines 0 comments Download
M src/string-iterator.js View 2 chunks +2 lines, -3 lines 0 comments Download
M src/symbol.js View 3 chunks +8 lines, -9 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 1 4 chunks +5 lines, -6 lines 0 comments Download
M src/typedarray.js View 2 chunks +22 lines, -22 lines 0 comments Download
M src/uri.js View 1 1 chunk +8 lines, -8 lines 0 comments Download
M src/v8natives.js View 1 8 chunks +111 lines, -110 lines 0 comments Download
M src/weak-collection.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
5 years, 8 months ago (2015-04-10 07:12:44 UTC) #1
Yang
On 2015/04/10 07:12:44, Yang wrote: Old stats: Deserialization will reserve: 856864 bytes for startup 210400 ...
5 years, 8 months ago (2015-04-10 07:26:14 UTC) #2
Jakob Kummerow
lgtm
5 years, 8 months ago (2015-04-10 08:06:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065863003/1
5 years, 8 months ago (2015-04-10 08:08:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065863003/20001
5 years, 8 months ago (2015-04-10 20:47:43 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-10 20:51:44 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 20:51:55 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fc0dec31c0633a4ca28d918d00852f915cf6ba28
Cr-Commit-Position: refs/heads/master@{#27760}

Powered by Google App Engine
This is Rietveld 408576698