Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1065813003: Apply automatic range checks to enum types across IPC. (Closed)

Created:
5 years, 8 months ago by payal.pandey
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, jam, Jered, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply automatic range checks to enum types across IPC. This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Committed: https://crrev.com/1eef00091473e5e77eed220fd3512f28c805eb9b Cr-Commit-Position: refs/heads/master@{#326571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M chrome/common/instant_types.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +9 lines, -5 lines 0 comments Download
M chrome/common/search_provider.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/public/common/top_controls_state.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
payal.pandey
Please have a look, Thanks
5 years, 8 months ago (2015-04-23 09:37:44 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-23 14:45:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065813003/1
5 years, 8 months ago (2015-04-23 16:24:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/58469)
5 years, 8 months ago (2015-04-23 16:33:05 UTC) #7
dcheng
lgtm
5 years, 8 months ago (2015-04-23 16:35:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065813003/1
5 years, 8 months ago (2015-04-23 17:42:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 17:49:01 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 17:49:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1eef00091473e5e77eed220fd3512f28c805eb9b
Cr-Commit-Position: refs/heads/master@{#326571}

Powered by Google App Engine
This is Rietveld 408576698