Show issue owner info in 'git cl status'

Show issue owner info in 'git cl status'

The name and email of the issue owner of the current change list would
be shown in command 'git cl status'.

[wychen, 2015-04-07 03:12:01]

wychen@chromium.org changed reviewers:
+ maruel@chromium.org

[wychen, 2015-04-07 03:12:02]

PTAL.

[M-A Ruel, 2015-04-07 13:08:50]

Why?

At best, it would only be printed in big red when it's mismatched from what
would be expected, but that means knowing what is expected first.

[wychen, 2015-04-07 17:18:37]

On 2015/04/07 13:08:50, M-A Ruel wrote:
> Why?
> 
> At best, it would only be printed in big red when it's mismatched from what
> would be expected, but that means knowing what is expected first.

Part of the reason is to expose the author information for this CL:
https://codereview.chromium.org/1052803002/patch/40001/50001

For normal users, this could be helpful if many CLs from different authors are
imported (git cl patch) locally.

Do you think it would be better to just expose the author in "git cl status
--field=author" instead?

[M-A Ruel, 2015-04-07 17:26:04]

maruel@chromium.org changed reviewers:
+ phajdan.jr@chromium.org
- maruel@chromium.org

[M-A Ruel, 2015-04-07 17:26:31]

On 2015/04/07 17:18:37, wychen wrote:
> On 2015/04/07 13:08:50, M-A Ruel wrote:
> > Why?
> > 
> > At best, it would only be printed in big red when it's mismatched from what
> > would be expected, but that means knowing what is expected first.
> 
> Part of the reason is to expose the author information for this CL:
> https://codereview.chromium.org/1052803002/patch/40001/50001
> 
> For normal users, this could be helpful if many CLs from different authors are
> imported (git cl patch) locally.
> 
> Do you think it would be better to just expose the author in "git cl status
> --field=author" instead?

Ok, redirecting to Paweł so he can make a more informed decision.

[Paweł Hajdan Jr., 2015-04-08 09:37:40]

LGTM

[wychen, 2015-04-08 16:20:26]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2015-04-08 16:20:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1065803002/1

[commit-bot: I haz the power, 2015-04-08 16:23:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-08 16:23:43]

Presubmit check for 1065803002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    depot_tools/git_cl.py

tests/gclient_smoketest.py (53.80s) failed
Ffatal: reference is not a tree: 3c8ab692187dc2b12b28de5bb131256b3908fc48
EE..............................................
======================================================================
ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest)
Like testBlinkDEPSChangeUsingGclient, but move the main project using
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1630, in testBlinkDEPSChangeUsingGit
    cwd=self.checkout_path)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
484, in check_call
    check_call_out(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
478, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git checkout -q
3c8ab692187dc2b12b28de5bb131256b3908fc48 returned non-zero exit status 128 in
/tmp/trialNQgv2j/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src

======================================================================
ERROR: testBlinkLocalBranchesArePreserved
(__main__.BlinkDEPSTransitionSmokeTest)
Checks that the state of local git branches are effectively preserved
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1656, in
testBlinkLocalBranchesArePreserved
    self.CheckStatusPreMergePoint()
  File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint
    self.blink), self.blink_git_url)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line
121, in Capture
    cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
449, in communicate
    proc = Popen(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
253, in __init__
    % (str(e), kwargs.get('cwd'), args[0]))
OSError: Execution failed with error: [Errno 2] No such file or directory:
'/tmp/trialNQgv2j/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'.
Check that
/tmp/trialNQgv2j/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit
or git exist and have execution permission.

======================================================================
FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest)
Checks that {src,blink} repos are consistent when syncing going back and
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1601, in
testBlinkDEPSChangeUsingGclient
    self.assertEqual(res[2], 0, 'DEPS change sync failed.')
AssertionError: DEPS change sync failed.

----------------------------------------------------------------------
Ran 49 tests in 53.584s

FAILED (failures=1, errors=2)


Presubmit checks took 174.7s to calculate.

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[wychen, 2015-04-08 16:31:00]

wychen@chromium.org changed reviewers:
+ iannucci@chromium.org

[wychen, 2015-04-08 16:31:01]

Robbie, can you take a look as the owner? Thanks!