Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1065783002: Remove legacy markup box behavior when line-clamping. (Closed)

Created:
5 years, 8 months ago by wkorman
Modified:
5 years, 8 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, Dominik Röttsches, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove legacy forced display/hit-testing of trailing anchor text when line-clamping. Summarizing the legacy behavior: clamped text would be ellipsified, but there was a special case where trailing anchor text, if any, would always be painted and hit-tested. This was intended to allow behavior as "Some text... [More]" where "[More]" was an anchor link and certain to be shown. There are alternate ways to achieve this behavior, so we simplify the code via removal. BUG=474343 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193299

Patch Set 1 #

Patch Set 2 : Remove obsolete fast/flexbox/line-clamp-link-after-ellipsis.html LayoutTest. #

Patch Set 3 : Rename new layout test to reflect intent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -116 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
D LayoutTests/fast/flexbox/line-clamp-link-after-ellipsis.html View 1 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/fast/flexbox/line-clamp-link-after-ellipsis-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
A LayoutTests/fast/overflow/line-clamp-hides-trailing-anchor.html View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/fast/overflow/line-clamp-hides-trailing-anchor-expected.html View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 2 chunks +2 lines, -13 lines 0 comments Download
M Source/core/layout/line/EllipsisBox.h View 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/layout/line/EllipsisBox.cpp View 2 chunks +0 lines, -30 lines 0 comments Download
M Source/core/layout/line/RootInlineBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/RootInlineBox.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/paint/EllipsisBoxPainter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/EllipsisBoxPainter.cpp View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
wkorman
5 years, 8 months ago (2015-04-07 01:36:26 UTC) #2
chrishtr
lgtm
5 years, 8 months ago (2015-04-07 18:03:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065783002/40001
5 years, 8 months ago (2015-04-07 18:03:41 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 20:34:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193299

Powered by Google App Engine
This is Rietveld 408576698