Move Media Router resource files into .grdp.

Move Media Router resource files into .grdp.

This moves the current Media Router resource files from the general browser_resources.grd to a separate .grdp file. Future files will also be added here.

BUG=464222
Committed: https://crrev.com/b8819267417da248aa4fe829c5fcf0965e17b0c3
Cr-Commit-Position: refs/heads/master@{#324057}

[apacible, 2015-04-07 00:50:09]

apacible@chromium.org changed reviewers:
+ jhawkins@chromium.org

[apacible, 2015-04-07 00:53:14]

PTAL, thanks!

[James Hawkins, 2015-04-07 15:18:17]

https://codereview.chromium.org/1065773002/diff/1/chrome/browser/browser_reso...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/1065773002/diff/1/chrome/browser/browser_reso...
chrome/browser/browser_resources.grd:451: <part
file="media_router_resources.grdp" />
This should be behind the <if>, right?

[apacible, 2015-04-07 15:27:43]

Patchset #2 (id:20001) has been deleted

[apacible, 2015-04-07 15:31:09]

https://codereview.chromium.org/1065773002/diff/1/chrome/browser/browser_reso...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/1065773002/diff/1/chrome/browser/browser_reso...
chrome/browser/browser_resources.grd:451: <part
file="media_router_resources.grdp" />
On 2015/04/07 15:18:17, James Hawkins wrote:
> This should be behind the <if>, right?

I followed the components_resources.grd style, since I didn't find any current
<part> in this one. I put the <if> in media_router_resources.grdp.

<part> is included under <includes>, but no <if>s.
https://code.google.com/p/chromium/codesearch#chromium/src/components/resourc...

printing_resources.grdp has the <if>.
https://code.google.com/p/chromium/codesearch#chromium/src/components/resourc...

[James Hawkins, 2015-04-07 15:33:48]

https://codereview.chromium.org/1065773002/diff/1/chrome/browser/browser_reso...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/1065773002/diff/1/chrome/browser/browser_reso...
chrome/browser/browser_resources.grd:451: <part
file="media_router_resources.grdp" />
On 2015/04/07 15:31:09, apacible wrote:
> On 2015/04/07 15:18:17, James Hawkins wrote:
> > This should be behind the <if>, right?
> 
> I followed the components_resources.grd style, since I didn't find any current
> <part> in this one. I put the <if> in media_router_resources.grdp.
> 
> <part> is included under <includes>, but no <if>s.
>
https://code.google.com/p/chromium/codesearch#chromium/src/components/resourc...
> 
> printing_resources.grdp has the <if>.
>
https://code.google.com/p/chromium/codesearch#chromium/src/components/resourc...

OK; I don't think that was done correctly.  If we have an entire feature that is
behind a flag, let's have the <if> be outside of it's inclusion (i.e., <part>).

[apacible, 2015-04-07 15:37:32]

https://codereview.chromium.org/1065773002/diff/1/chrome/browser/browser_reso...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/1065773002/diff/1/chrome/browser/browser_reso...
chrome/browser/browser_resources.grd:451: <part
file="media_router_resources.grdp" />
On 2015/04/07 15:33:48, James Hawkins wrote:
> On 2015/04/07 15:31:09, apacible wrote:
> > On 2015/04/07 15:18:17, James Hawkins wrote:
> > > This should be behind the <if>, right?
> > 
> > I followed the components_resources.grd style, since I didn't find any
current
> > <part> in this one. I put the <if> in media_router_resources.grdp.
> > 
> > <part> is included under <includes>, but no <if>s.
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/components/resourc...
> > 
> > printing_resources.grdp has the <if>.
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/components/resourc...
> 
> OK; I don't think that was done correctly.  If we have an entire feature that
is
> behind a flag, let's have the <if> be outside of it's inclusion (i.e.,
<part>).

I see. I've moved the <if> out of the .grdp and into the .grd.

[James Hawkins, 2015-04-07 15:53:16]

lgtm

[apacible, 2015-04-07 15:55:15]

The CQ bit was checked by apacible@chromium.org

[commit-bot: I haz the power, 2015-04-07 15:55:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1065773002/40001

[commit-bot: I haz the power, 2015-04-07 16:47:02]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-04-07 17:00:07]

Patchset 2 (id:??) landed as
https://crrev.com/b8819267417da248aa4fe829c5fcf0965e17b0c3
Cr-Commit-Position: refs/heads/master@{#324057}