media/midi/usb_midi_output_stream.cc - Issue 1065743003: Reland: Web MIDI: split build rules for media/midi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/midi/usb_midi_output_stream.cc

Issue 1065743003: Reland: Web MIDI: split build rules for media/midi (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed patch set Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/midi/usb_midi_output_stream.cc

diff --git a/media/midi/usb_midi_output_stream.cc b/media/midi/usb_midi_output_stream.cc

index 2f3289754f082edcae351fa7e5fab3ac0f95ffbe..8f1af70e926b24802dec1c90a5d1374f5a7daec2 100644

--- a/media/midi/usb_midi_output_stream.cc

+++ b/media/midi/usb_midi_output_stream.cc

@@ -98,7 +98,7 @@ bool UsbMidiOutputStream::PushSysExMessage(const std::vector<uint8>& data,

message[message_size] = byte;

++message_size;

if (byte == kEndOfSysExByte) {

- uint8 code_index = message_size + 0x4;

+ uint8 code_index = static_cast<uint8>(message_size) + 0x4;

DCHECK(code_index == 0x5 || code_index == 0x6 || code_index == 0x7);

data_to_send->push_back((jack_.cable_number << 4) | code_index);

data_to_send->insert(data_to_send->end(),