remoting/webapp/crd/js/mock_xhr.js - Issue 1065733004: Added partial unit tests for host_controller.js. More to come.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/mock_xhr.js

Issue 1065733004: Added partial unit tests for host_controller.js. More to come. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hdf-unittest

Patch Set: for review Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/webapp/crd/js/host_controller_unittest.js ('K') | « remoting/webapp/crd/js/mock_host_daemon_facade.js ('k') | remoting/webapp/crd/js/mock_xhr_unittest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/webapp/crd/js/mock_xhr.js

diff --git a/remoting/webapp/crd/js/mock_xhr.js b/remoting/webapp/crd/js/mock_xhr.js

index 706badbf82fbc69d44afc39953c51a52606a9ec2..4fa5954acd8e798e5ad2bbb490243fe7023f6f23 100644

--- a/remoting/webapp/crd/js/mock_xhr.js

+++ b/remoting/webapp/crd/js/mock_xhr.js

@@ -184,12 +184,14 @@ remoting.MockXhr.setResponseFor = function(

* @param {?string} method

* @param {?string|!RegExp} urlPattern

+ * @param {number=} opt_status

* @param {boolean=} opt_reuse

-remoting.MockXhr.setEmptyResponseFor = function(method, urlPattern, opt_reuse) {

+remoting.MockXhr.setEmptyResponseFor = function(

+ method, urlPattern, opt_status, opt_reuse) {

remoting.MockXhr.setResponseFor(

method, urlPattern, function(/** remoting.MockXhr */ xhr) {

- xhr.setEmptyResponse(204);

+ xhr.setEmptyResponse(opt_status == null ? 204 : opt_status);

}, opt_reuse);

};