Added partial unit tests for host_controller.js. More to come.

remoting/webapp/base/js/base.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * A module that contains basic utility components and methods for the
  * chromoting project
  *
  */
@@ skipping 38 matching lines @@
   } catch (/** @type {Error} */ error) {
     var callstack = error.stack
       .replace(/^\s+(at eval )?at\s+/gm, '') // Remove 'at' and indentation.
       .split('\n');
     callstack.splice(0,2); // Remove the stack of the current function.
   }
   return callstack.join('\n');
 };
 
 /**
+ * @param {*} value
+ * @return T
+ * @template T
+ */
+base.reinterpret_cast = function(value) {

[Jamie, 2015/04/07 01:13:11]

You don't seem to be using this.

[John Williams, 2015/04/07 20:10:25]

Yeah, I thought this would make certain casts less painful but it turned out not
to work.

Removed.

+  return value;
+};
+
+/**
   * @interface
   */
 base.Disposable = function() {};
 base.Disposable.prototype.dispose = function() {};
 
 /**
  * @constructor
  * @param {...base.Disposable} var_args
  * @implements {base.Disposable}
  */
@@ skipping 658 matching lines @@
  */
 base.resizeWindowToContent = function() {
   var appWindow = chrome.app.window.current();
   var outerBounds = appWindow.outerBounds;
   var borderY = outerBounds.height - appWindow.innerBounds.height;
   appWindow.resizeTo(outerBounds.width, document.body.clientHeight + borderY);
   // Sometimes, resizing the window causes its position to be reset to (0, 0),
   // so restore it explicitly.
   appWindow.moveTo(outerBounds.left, outerBounds.top);
 };
+
+/**
+ * @return {string} A random UUID.
+ */
+base.generateUuid = function() {

[Jamie, 2015/04/07 01:13:12]

Move this up below generateXsrfToken, since it's conceptually similar.

[John Williams, 2015/04/07 20:10:25]

Done.

+  var random = new Uint16Array(8);
+  window.crypto.getRandomValues(random);
+  /** @type {Array<string>} */
+  var e = new Array();
+  for (var i = 0; i < 8; i++) {
+    e[i] = (/** @type {number} */ (random[i]) + 0x10000).
+        toString(16).substring(1);
+  }
+  return e[0] + e[1] + '-' + e[2] + '-' + e[3] + '-' +
+      e[4] + '-' + e[5] + e[6] + e[7];
+};