Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1065733003: PPAPI Examples: Fix painting in Graphics 2D example. (Closed)

Created:
5 years, 8 months ago by tommycli
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PPAPI Examples: Fix painting in Graphics 2D example. Releasing the Graphics2D at the end of the Repaint method causes the blue image to never be visible to anyone who runs the 2d.html example. (At least on Linux) This saves the created Graphics 2D, saves it, and releases it when the plugin instance is destroyed. BUG= Committed: https://crrev.com/a1b9fb3524473610a204e2c39ecd681f67d3db20 Cr-Commit-Position: refs/heads/master@{#324059}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : add periods #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M ppapi/examples/2d/graphics_2d_example.c View 1 2 5 chunks +14 lines, -11 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
tommycli
dmichael: PTAL Not sure if I'm misunderstanding Graphics2D, but it wasn't working on my machine ...
5 years, 8 months ago (2015-04-06 22:59:48 UTC) #2
dmichael (off chromium)
What a weird old example! It probably worked 4-5 years ago in the in-process mode ...
5 years, 8 months ago (2015-04-07 15:33:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065733003/40001
5 years, 8 months ago (2015-04-07 16:20:20 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-07 16:59:04 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 17:01:27 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a1b9fb3524473610a204e2c39ecd681f67d3db20
Cr-Commit-Position: refs/heads/master@{#324059}

Powered by Google App Engine
This is Rietveld 408576698