Issue 106573003: Revert 242029 "Omnibox: Bug Fixes for Shortcuts Inlining"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 106573003: Revert 242029 "Omnibox: Bug Fixes for Shortcuts Inlining" (Closed)

Created:
7 years ago by Mark P

Modified:
7 years ago

Reviewers:
Mark P

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 242029 "Omnibox: Bug Fixes for Shortcuts Inlining" Accidentally didn't check in the latest patch of this changeset. > Omnibox: Bug Fixes for Shortcuts Inlining > > Precisely, fixes up URL-like inputs before comparing to the shortcuts > fill_into_edit in order to better determine inlineability. > > This is especially useful for inputs such as about: which need to have > their scheme fixed up to be recognized as comparable to chrome:// > shortcuts. > > BUG=328220 > > Review URL: https://codereview.chromium.org/108643003 TBR=mpearson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242106

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -137 lines)			Patch
M	trunk/src/chrome/browser/autocomplete/history_provider.h	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	trunk/src/chrome/browser/autocomplete/history_provider.cc	View	3 chunks	+24 lines, -23 lines	0 comments	Download
M	trunk/src/chrome/browser/autocomplete/shortcuts_provider.h	View	3 chunks	+5 lines, -20 lines	0 comments	Download
M	trunk/src/chrome/browser/autocomplete/shortcuts_provider.cc	View	8 chunks	+15 lines, -36 lines	0 comments	Download
M	trunk/src/chrome/browser/autocomplete/shortcuts_provider_unittest.cc	View	2 chunks	+0 lines, -48 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r242106.

Expand Messages | Collapse Messages