Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issue 1065723003: Teach skydb about the --trace-startup flag (Closed)

Created:
5 years, 8 months ago by jamesr
Modified:
5 years, 8 months ago
Reviewers:
eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Teach skydb about the --trace-startup flag This flag to mojo_shell is gaining the ability to produce tracing info starting very early in process startup. This allows the skydb 'start' command to pass this command through to mojo_shell. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9604c53f1e586326ec4a0cad936e4509d7e66613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M sky/tools/skydb View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jamesr
5 years, 8 months ago (2015-04-06 22:50:17 UTC) #1
eseidel
lgtm
5 years, 8 months ago (2015-04-06 23:13:54 UTC) #2
jamesr
5 years, 8 months ago (2015-04-06 23:14:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9604c53f1e586326ec4a0cad936e4509d7e66613 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698