Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1065683002: Switch textures created by DeviceImageFilterProxy to approx-match. (Closed)

Created:
5 years, 8 months ago by Stephen White
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Switch textures created by DeviceImageFilterProxy to approx-match. This revealed some further 0..1 texture coordinate depedencies,specifically in SkDisplacementMapEffect and SkXfermodeImageFilter, fixed through use of GrTextureDomain. Note: causes minor pixel diffs in pictureimagefilter, testimagefilters GMs. Also causes minor pixel diffs in some Blink layout tests, suppressed here: https://codereview.chromium.org/1064943002 BUG=skia:3532 Committed: https://skia.googlesource.com/skia/+/d762ca2586707cb808342b11832073e8b3df33ad

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix trailing semicolon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M src/core/SkDeviceImageFilterProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 12 chunks +25 lines, -18 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Stephen White
robertphillips@: PTAL. Thanks!
5 years, 8 months ago (2015-04-06 20:00:30 UTC) #2
robertphillips
lgtm. So there is no way to have repeating image filters? https://codereview.chromium.org/1065683002/diff/1/src/effects/SkDisplacementMapEffect.cpp File src/effects/SkDisplacementMapEffect.cpp (right): ...
5 years, 8 months ago (2015-04-07 13:25:46 UTC) #4
Stephen White
On 2015/04/07 13:25:46, robertphillips wrote: > lgtm. So there is no way to have repeating ...
5 years, 8 months ago (2015-04-07 15:41:47 UTC) #5
Stephen White
On 2015/04/07 15:41:47, Stephen White wrote: > On 2015/04/07 13:25:46, robertphillips wrote: > > lgtm. ...
5 years, 8 months ago (2015-04-07 15:43:28 UTC) #6
Stephen White
https://codereview.chromium.org/1065683002/diff/1/src/effects/SkDisplacementMapEffect.cpp File src/effects/SkDisplacementMapEffect.cpp (right): https://codereview.chromium.org/1065683002/diff/1/src/effects/SkDisplacementMapEffect.cpp#newcode364 src/effects/SkDisplacementMapEffect.cpp:364: const char* name() const override { return "DisplacementMap"; } ...
5 years, 8 months ago (2015-04-07 15:43:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065683002/20001
5 years, 8 months ago (2015-04-07 17:51:25 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 19:16:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d762ca2586707cb808342b11832073e8b3df33ad

Powered by Google App Engine
This is Rietveld 408576698