mojo/public/tools/bindings/generators/mojom_cpp_generator.py - Issue 1065653006: Array and map members for unions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

Issue 1065653006: Array and map members for unions. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

index 35dec210775e35409a0d65e38aa65a39811313d3..dbe977d6a4fa4c818644b2c51ccb31978c1df7c7 100644

--- a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

@@ -228,7 +228,8 @@ def GetCppFieldType(kind):

return _kind_to_cpp_type[kind]

def GetUnionGetterReturnType(kind):

- if mojom.IsStructKind(kind):

+ if (mojom.IsStructKind(kind) or mojom.IsArrayKind(kind) or

+ mojom.IsMapKind(kind)):

return "%s&" % GetCppWrapperType(kind)

return GetCppResultWrapperType(kind)