Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 106563002: Delete all invalidated resources with same key (Closed)

Created:
7 years ago by Kimmo Kinnunen
Modified:
6 years, 11 months ago
Reviewers:
Kimmo Kinnunen, mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Delete all invalidated resources with same key Delete all invalidated resources with same key instead of deleting just the first resource. Committed: http://code.google.com/p/skia/source/detail?r=13019 BUG=

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -2 lines) Patch
M src/gpu/GrResourceCache.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 3 chunks +75 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Kimmo Kinnunen
7 years ago (2013-12-05 14:45:50 UTC) #1
Kimmo Kinnunen
Due to test, depends on https://codereview.chromium.org/91453002/
7 years ago (2013-12-05 14:46:23 UTC) #2
mtklein
I think we can land this one right away. I have taken the liberty of ...
6 years, 11 months ago (2014-01-09 16:44:59 UTC) #3
Kimmo Kinnunen
On 2014/01/09 16:44:59, mtklein wrote: > I think we can land this one right away. ...
6 years, 11 months ago (2014-01-10 06:42:50 UTC) #4
mtklein
lgtm
6 years, 11 months ago (2014-01-10 14:11:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/106563002/40001
6 years, 11 months ago (2014-01-10 14:11:44 UTC) #6
commit-bot: I haz the power
Change committed as 13019
6 years, 11 months ago (2014-01-10 16:39:23 UTC) #7
mtklein
6 years, 11 months ago (2014-01-10 17:58:15 UTC) #8
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/134363002/ by mtklein@google.com.

The reason for reverting is: There's a threading issue I don't quite understand
yet.  Objects are being deleted after we check they're deleted.  Will try
again..

Powered by Google App Engine
This is Rietveld 408576698