Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 106553004: components: Remove 'ui' dependencies from json_schema and user_prefs targets. (Closed)

Created:
7 years ago by tfarina
Modified:
7 years ago
Reviewers:
Jói
CC:
chromium-reviews
Visibility:
Public.

Description

components: Remove 'ui' dependencies from json_schema and user_prefs targets. BUG=302505 TEST=None TBR=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M components/json_schema.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/json_schema/json_schema_validator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/user_prefs.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
tfarina
TBRing...
7 years ago (2013-12-14 20:05:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/106553004/1
7 years ago (2013-12-14 20:06:10 UTC) #2
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=202538
7 years ago (2013-12-14 21:02:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/106553004/1
7 years ago (2013-12-15 00:20:36 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204296
7 years ago (2013-12-15 00:51:56 UTC) #5
Jói
LGTM On Sat, Dec 14, 2013 at 8:05 PM, <tfarina@chromium.org> wrote: > Reviewers: Jói, > ...
7 years ago (2013-12-16 12:28:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/106553004/1
7 years ago (2013-12-16 12:30:14 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204676
7 years ago (2013-12-16 13:34:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/106553004/1
7 years ago (2013-12-16 15:06:31 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204760
7 years ago (2013-12-16 15:48:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/106553004/1
7 years ago (2013-12-16 16:17:22 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204844
7 years ago (2013-12-16 17:28:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/106553004/1
7 years ago (2013-12-16 17:32:52 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204950
7 years ago (2013-12-16 19:00:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/106553004/1
7 years ago (2013-12-16 20:19:52 UTC) #15
commit-bot: I haz the power
7 years ago (2013-12-16 22:26:22 UTC) #16
Message was sent while issue was closed.
Change committed as 241047

Powered by Google App Engine
This is Rietveld 408576698