tools/skp/recreate_skps.py - Issue 1065503007: Update RecreateSKPs bot to also generate Slimming Paint SKPs with a separate prefix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skp/recreate_skps.py

Issue 1065503007: Update RecreateSKPs bot to also generate Slimming Paint SKPs with a separate prefix (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Cleanup Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/skp/recreate_skps.py

diff --git a/tools/skp/recreate_skps.py b/tools/skp/recreate_skps.py

index a2c24df560b16a5e250a1bb6bb01535b9f5ef180..ad3b38e2bf8221408c3df0624d652b181143749b 100644

--- a/tools/skp/recreate_skps.py

+++ b/tools/skp/recreate_skps.py

@@ -64,6 +64,12 @@ def main(chrome_src_path, browser_executable):

try:

shell_utils.run(webpages_playback_cmd)

+ # Temporary change to enable Slimming Paint runs. See skia:3763.

+ webpages_playback_cmd.extend([

+ '--skp_prefix', 'sp_',

+ '--browser_extra_args', '--enable-slimming-paint',

+ ])

+ shell_utils.run(webpages_playback_cmd)

finally:

# Clean up any leftover browser instances. This can happen if there are

# telemetry crashes, processes are not always cleaned up appropriately by

« no previous file with comments | « no previous file | no next file » | no next file with comments »