Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 1065503002: sandbox/linux/syscall_broker: Remove includes of of basictypes.h header. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org, jln (very slow on Chromium), viettrungluu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sandbox/linux/syscall_broker: Remove includes of of basictypes.h header. They were basically including it for DISALLOW macros. BUG=138542 TEST=sandbox_linux_unittests R=mdempsky@chromium.org Committed: https://crrev.com/e957b3aaa8fe89f276c26205ce60398ee73791e0 Cr-Commit-Position: refs/heads/master@{#323883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M sandbox/linux/syscall_broker/broker_process.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/syscall_broker/broker_process_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 8 months ago (2015-04-04 17:16:40 UTC) #1
mdempsky
lgtm
5 years, 8 months ago (2015-04-04 17:46:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065503002/1
5 years, 8 months ago (2015-04-04 17:46:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-04 17:54:39 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-04 17:55:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e957b3aaa8fe89f276c26205ce60398ee73791e0
Cr-Commit-Position: refs/heads/master@{#323883}

Powered by Google App Engine
This is Rietveld 408576698