Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 1065453003: Revert of mac: Weakly link against the CoreBluetooth framework. (Closed)

Created:
5 years, 8 months ago by erikchen
Modified:
5 years, 8 months ago
Reviewers:
Robert Sesek, keybuk
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Weakly link against the CoreBluetooth framework. (patchset #2 id:80001 of https://codereview.chromium.org/1101513003/) Reason for revert: The GN file wasn't formatted correctly. http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/8764/steps/compile/logs/stdio Original issue's description: > mac: Weakly link against the CoreBluetooth framework. > > In the OSX 10.10 SDK, CoreBluetooth became a top level framework. Previously, > it was nested in IOBluetooth. In order for Chrome to run on OSes older than OSX > 10.10, the top level CoreBluetooth framework must be weakly linked. > > BUG=463170 > > Committed: https://crrev.com/9fde3e00865650009c7e85fcb7157719372b97a8 > Cr-Commit-Position: refs/heads/master@{#326705} TBR=rsesek@chromium.org,keybuk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463170 Committed: https://crrev.com/b86c45ca4b1d84748a5543ee85fa1ba38c8ee677 Cr-Commit-Position: refs/heads/master@{#326708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M device/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of mac: Weakly link against the CoreBluetooth framework.
5 years, 8 months ago (2015-04-24 00:54:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065453003/1
5 years, 8 months ago (2015-04-24 00:55:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 00:56:21 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 00:57:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b86c45ca4b1d84748a5543ee85fa1ba38c8ee677
Cr-Commit-Position: refs/heads/master@{#326708}

Powered by Google App Engine
This is Rietveld 408576698