Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1065433002: Simplify some mojo_shell code. (Closed)

Created:
5 years, 8 months ago by jam
Modified:
5 years, 8 months ago
Reviewers:
cpu_(ooo_6.6-7.5), sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify some mojo_shell code. -make desktop/main.cc be a near empty file that calls out to separate files for main ("launcher" per naming discussions) or child process -remove ChildProcess and derived classs; one method is enough -remove unused mojo/shell/launcher_main.cc -use a more reasonable size window on desktop Committed: https://crrev.com/edc54e0f7f19fbd76a84d470fec909631740c560 Cr-Commit-Position: refs/heads/master@{#323964}

Patch Set 1 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -780 lines) Patch
M mojo/services/kiosk_wm/kiosk_wm.cc View 1 chunk +1 line, -2 lines 4 comments Download
M mojo/shell/BUILD.gn View 5 chunks +8 lines, -26 lines 0 comments Download
D mojo/shell/app_child_process.h View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/shell/app_child_process.cc View 1 chunk +0 lines, -302 lines 0 comments Download
M mojo/shell/child_process.h View 1 chunk +5 lines, -39 lines 0 comments Download
M mojo/shell/child_process.cc View 1 chunk +282 lines, -16 lines 0 comments Download
A mojo/shell/desktop/launcher_process.h View 1 chunk +17 lines, -0 lines 0 comments Download
A + mojo/shell/desktop/launcher_process.cc View 4 chunks +55 lines, -70 lines 0 comments Download
M mojo/shell/desktop/main.cc View 1 chunk +6 lines, -167 lines 0 comments Download
D mojo/shell/launcher_main.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M mojo/shell/shell_test_main.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M mojo/shell/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/switches.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
jam
5 years, 8 months ago (2015-04-03 22:46:01 UTC) #3
jam
or sky if he gets to this first
5 years, 8 months ago (2015-04-03 23:27:27 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm I don't fully follow the gn changes but that has never stopped me in ...
5 years, 8 months ago (2015-04-06 20:43:48 UTC) #6
jam
https://codereview.chromium.org/1065433002/diff/20001/mojo/services/kiosk_wm/kiosk_wm.cc File mojo/services/kiosk_wm/kiosk_wm.cc (right): https://codereview.chromium.org/1065433002/diff/20001/mojo/services/kiosk_wm/kiosk_wm.cc#newcode57 mojo/services/kiosk_wm/kiosk_wm.cc:57: On 2015/04/06 20:43:48, cpu wrote: > ifdef(os_win) ? > ...
5 years, 8 months ago (2015-04-06 22:02:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065433002/20001
5 years, 8 months ago (2015-04-06 22:03:13 UTC) #9
jam
btw the gn changes are just removing a target that's only used for the ensemble ...
5 years, 8 months ago (2015-04-06 22:03:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 8 months ago (2015-04-06 22:30:16 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/edc54e0f7f19fbd76a84d470fec909631740c560 Cr-Commit-Position: refs/heads/master@{#323964}
5 years, 8 months ago (2015-04-06 22:31:40 UTC) #12
sky
https://codereview.chromium.org/1065433002/diff/20001/mojo/services/kiosk_wm/kiosk_wm.cc File mojo/services/kiosk_wm/kiosk_wm.cc (right): https://codereview.chromium.org/1065433002/diff/20001/mojo/services/kiosk_wm/kiosk_wm.cc#newcode57 mojo/services/kiosk_wm/kiosk_wm.cc:57: On 2015/04/06 22:02:51, jam wrote: > On 2015/04/06 20:43:48, ...
5 years, 8 months ago (2015-04-08 19:17:46 UTC) #13
jam
5 years, 8 months ago (2015-04-10 01:29:56 UTC) #14
Message was sent while issue was closed. 
https://codereview.chromium.org/1065433002/diff/20001/mojo/services/kiosk_wm/...
File mojo/services/kiosk_wm/kiosk_wm.cc (right):

https://codereview.chromium.org/1065433002/diff/20001/mojo/services/kiosk_wm/...
mojo/services/kiosk_wm/kiosk_wm.cc:57: 
On 2015/04/08 19:17:46, sky wrote:
> On 2015/04/06 22:02:51, jam wrote:
> > On 2015/04/06 20:43:48, cpu wrote:
> > > ifdef(os_win) ?
> > > 
> > > I mean keep both sizes
> > 
> > this is only used on desktop, so it's not hit on android
> 
> Actually, we do use this on the device as well. I suspect we won't long term,
> but in the short term we do.

ah I was mistaken, thanks for clarifying. I'll undo this for android

Powered by Google App Engine
This is Rietveld 408576698