Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: BUILD.gn

Issue 1065403002: Windows GN component build fixes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 34500fe01b9f013fcdaeca9a87f4341bf3053174..98987df839b12ce3be41f86433b8fb13902bdc73 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -1527,7 +1527,7 @@ if (component_mode == "shared_library") {
":toolchain",
]
- direct_dependent_configs = [ ":external_config" ]
+ public_configs = [ ":external_config" ]
libs = []
if (is_android && current_toolchain != host_toolchain) {
@@ -1554,7 +1554,7 @@ if (component_mode == "shared_library") {
]
}
- direct_dependent_configs = [ ":external_config" ]
+ public_configs = [ ":external_config" ]
}
}
@@ -1571,7 +1571,10 @@ if ((current_toolchain == host_toolchain && v8_toolset_for_d8 == "host") ||
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
configs += [
- ":internal_config",
+ # Note: don't use :internal_config here because this target will get
+ # the :external_config applied to it by virtue of depending on :v8, and
+ # you can't have both applied to the same target.
+ ":internal_config_base",
":features",
":toolchain",
]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698