Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 1065403002: Windows GN component build fixes. (Closed)

Created:
5 years, 8 months ago by brettw
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Windows GN component build fixes. This fixes the d8 target which previously was getting both USING_V8_SHARED and BUILDING_V8_SHARED defined at the same time. Renames direct_dependent_configs to public_configs (new name, same thing). Committed: https://crrev.com/3f036fc0ba4ca4483fe77822f8605c277d37ee24 Cr-Commit-Position: refs/heads/master@{#27713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M BUILD.gn View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
If you could also land this for me if it looks OK, that would me ...
5 years, 8 months ago (2015-04-08 20:01:14 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-09 14:36:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065403002/1
5 years, 8 months ago (2015-04-09 14:36:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 19:36:06 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 19:36:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f036fc0ba4ca4483fe77822f8605c277d37ee24
Cr-Commit-Position: refs/heads/master@{#27713}

Powered by Google App Engine
This is Rietveld 408576698