Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Issue 1065393002: leveldb: Move GN build file from secondary tree to the main tree. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
brettw, cmumford
CC:
chromium-reviews, Dirk Pranke, jsbell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

leveldb: Move GN build file from secondary tree to the main tree. There seems to be no reason to keep it out there. It just work just fine in the main tree. BUG=None TEST=gn gen out-gn still works R=cmumford@chromium.org Committed: https://crrev.com/f11743d6ccb6172546c5d33b758b6b6b66ef4181 Cr-Commit-Position: refs/heads/master@{#324542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -339 lines) Patch
D build/secondary/third_party/leveldatabase/BUILD.gn View 1 chunk +0 lines, -340 lines 0 comments Download
A + third_party/leveldatabase/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
tfarina
5 years, 8 months ago (2015-04-08 20:17:01 UTC) #1
tfarina
Chris, friendly ping?
5 years, 8 months ago (2015-04-09 19:27:43 UTC) #2
cmumford
On 2015/04/09 at 19:27:43, tfarina wrote: > Chris, friendly ping? I have no idea what ...
5 years, 8 months ago (2015-04-09 21:16:58 UTC) #3
tfarina
Brett, could you review this?
5 years, 8 months ago (2015-04-09 21:45:17 UTC) #5
brettw
lgtm
5 years, 8 months ago (2015-04-09 21:48:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1065393002/1
5 years, 8 months ago (2015-04-09 23:10:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 23:57:04 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 23:57:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f11743d6ccb6172546c5d33b758b6b6b66ef4181
Cr-Commit-Position: refs/heads/master@{#324542}

Powered by Google App Engine
This is Rietveld 408576698